Jira (PUP-4713) Race condition in node/environment.rb's modules_by_path

2 views
Skip to first unread message

Kylo Ginsberg (JIRA)

unread,
Jun 8, 2015, 7:51:55 PM6/8/15
to puppe...@googlegroups.com
Kylo Ginsberg created an issue
 
Puppet / Bug PUP-4713
Race condition in node/environment.rb's modules_by_path
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2015/06/08 4:51 PM
Priority: Normal Normal
Reporter: Kylo Ginsberg

Reviewing pup-3710, we opted to backport one change (see https://github.com/puppetlabs/puppet/pull/4015), but Branan Riley noted that there is a race condition in the original pe-puppet logic. Rather than check for the path existing and then chdir'ing to it, it should chdir and catch the exception.

Even better, it shouldn't chdir all over the place.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
Atlassian logo

Josh Cooper (JIRA)

unread,
May 16, 2017, 7:56:05 PM5/16/17
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Labels: help_wanted triaged
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Josh Cooper (JIRA)

unread,
Oct 1, 2019, 1:22:03 AM10/1/19
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-4713
 
Re: Race condition in node/environment.rb's modules_by_path

Closing this in favor of PUP-9997, to not chdir since we may not be able to chdir back when the block finishes.

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages