Jira (PDB-1599) PR (1443): (maint) Provide /factsets/<node> endpoint - kbarber

1 view
Skip to first unread message

gepetto-bot (JIRA)

unread,
Jun 5, 2015, 1:27:14 PM6/5/15
to puppe...@googlegroups.com
gepetto-bot created an issue
 
PuppetDB / Task PDB-1599
PR (1443): (maint) Provide /factsets/<node> endpoint - kbarber
Issue Type: Task Task
Assignee: Unassigned
Created: 2015/06/05 10:26 AM
Labels: github
Priority: Normal Normal
Reporter: gepetto-bot

(maint) Provide /factsets/<node> endpoint

Pull Request Description

We had missed this as a singleton query endpoint, this patch adds it.

Signed-off-by: Ken Barber <k...@bob.sh>

(webhooks-id: 95fe9e829ce89406341f995b0092d77a)
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
Atlassian logo

Kenneth Barber (JIRA)

unread,
Jun 5, 2015, 1:30:13 PM6/5/15
to puppe...@googlegroups.com
Kenneth Barber updated an issue
 
PuppetDB / New Feature PDB-1599
Change By: Kenneth Barber
Sprint: PuppetDB 2015-06-17
Story Points: 1
Scope Change Reason: I noticed this as part of PDB-1125, and it was trivial to fix
Scope Change Category: Adopted
Fix Version/s: PDB 3.0.0
Issue Type: Task New Feature

gepetto-bot (JIRA)

unread,
Jun 5, 2015, 2:28:09 PM6/5/15
to puppe...@googlegroups.com
gepetto-bot commented on New Feature PDB-1599
 
Re: PR (1443): (maint) Provide /factsets/<node> endpoint - kbarber

wkalt commented:

looks good to me aside from minor comments

gepetto-bot (JIRA)

unread,
Jun 5, 2015, 3:01:05 PM6/5/15
to puppe...@googlegroups.com
gepetto-bot commented on New Feature PDB-1599

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1400/

gepetto-bot (JIRA)

unread,
Jun 8, 2015, 11:15:53 AM6/8/15
to puppe...@googlegroups.com
gepetto-bot commented on New Feature PDB-1599

mullr commented:

generally lgtm, just the one question

gepetto-bot (JIRA)

unread,
Jun 8, 2015, 11:24:55 AM6/8/15
to puppe...@googlegroups.com
gepetto-bot commented on New Feature PDB-1599

mullr commented:

Just started reviewing <br><br>:octocat: *Sent from [GH](http://nodegh.io).*

gepetto-bot (JIRA)

unread,
Jun 8, 2015, 11:31:58 AM6/8/15
to puppe...@googlegroups.com
gepetto-bot commented on New Feature PDB-1599

mullr commented:

Tested locally, works fine.

gepetto-bot (JIRA)

unread,
Jun 9, 2015, 11:47:52 AM6/9/15
to puppe...@googlegroups.com
gepetto-bot commented on New Feature PDB-1599

pljenkinsro commented:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):

Kurt Wall (JIRA)

unread,
Jan 20, 2016, 1:45:22 PM1/20/16
to puppe...@googlegroups.com
Kurt Wall updated an issue
 
Change By: Kurt Wall
QA Status: Reviewed
QA Risk Assessment: Low
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Atlassian logo

Claudia Petty (Jira)

unread,
Jun 21, 2023, 10:59:55 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: github new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages