Jira (PUP-4514) Improve external syntax checking of heredoc

2 views
Skip to first unread message

Henrik Lindberg (JIRA)

unread,
May 2, 2015, 9:53:18 AM5/2/15
to puppe...@googlegroups.com
Henrik Lindberg created an issue
 
Puppet / Improvement PUP-4514
Improve external syntax checking of heredoc
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2015/05/02 6:53 AM
Fix Versions: PUP 4.x
Priority: Normal Normal
Reporter: Henrik Lindberg
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
May 2, 2015, 10:01:22 AM5/2/15
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Currently, the external syntax checkers are only checked after evaluation of the heredoc expression because a heredoc may include interpolations.
It should be possible to check the syntax of a heredoc that has static content at validation time (and then skip this check at evaluation time).

In order to achieve this the external_syntax_support must be modified  since it now requires scope to get to the compiler to get the injector to get the bound syntax checkers. (This should be refactored for other reasons as well).

The benefit of doing static validation of a heredoc is that static Json, Yaml, etc. or indeed inline EPP can be validated e.g. by writing:
{code:puppet}
inline_epp(@(END:epp))
  Hello <%= $name %>
END
{code}

Kylo Ginsberg (JIRA)

unread,
May 7, 2015, 7:01:25 PM5/7/15
to puppe...@googlegroups.com
Kylo Ginsberg updated an issue
Change By: Kylo Ginsberg
Scrum Team: Language

Henrik Lindberg (JIRA)

unread,
May 17, 2016, 9:19:32 PM5/17/16
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-4514
 
Re: Improve external syntax checking of heredoc

This should move to NPUP to be dealt with in some future...

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Sep 7, 2016, 6:12:26 PM9/7/16
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
 
Change By: Henrik Lindberg
Team: Puppet Developer Support
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Apr 25, 2017, 6:00:02 AM4/25/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 4.y
Fix Version/s: PUP 5.y

Ethan Brown (JIRA)

unread,
May 17, 2017, 1:52:03 PM5/17/17
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Team: Puppet Developer Experience Agent

Ethan Brown (JIRA)

unread,
May 17, 2017, 1:52:03 PM5/17/17
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Labels: triaged

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:44:50 PM5/18/17
to puppe...@googlegroups.com

Maggie Dreyer (JIRA)

unread,
Oct 29, 2018, 7:26:02 PM10/29/18
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
Change By: Maggie Dreyer
Team: Server Coremunity
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (Jira)

unread,
Feb 9, 2022, 12:43:02 AM2/9/22
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-4514
 
Re: Improve external syntax checking of heredoc

We don’t have plans on implementing this anytime soon so I’m going to close.

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages