Jira (PUP-4429) Puppet command line tools accept partial matches for flags without altering behavior

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen created an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior Issue Type: Bug Affects Versions: PUP 3.7.5, PUP 4.0.0 Assignee: Kylo Ginsberg Components: Client Created: 2015/04/16 2:35 PM Labels: redmine Priority: Normal Reporter: Charlie Sharpsteen The Puppet command line tools will accept partial matches for flags, but do not use the values provided. This causes unexpected behavior when a command accepts a flag or type but doesn't actually act upon it. Reproduction Case Install Puppet 3.7.x or 4.0.x. Execute config print commands with flags that affect settings, such as puppet agent - no-daemonize --configprint daemonize with various truncations of the -no-daemonize flag. Outcome Partial matches are accepted, but don't alter the setting value: puppet agent --no-daemon --configprint daemonize true   puppet agent --no-daemoniz --configprint daemonize true   # Correct behavior when flag is fully specified. puppet agent --no-daemonize --configprint daemonize false Expected Outcome The Puppet command line interface should treat partial flags the same way as missing flags and throw an 'invalid option' error: puppet agent --no-daemon Error: Could not parse application options: invalid option: --no-daemon Add Comment

This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Kylo Ginsberg Scrum Team: Client Platform

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Kylo Ginsberg Labels: cli redmine

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg commented on PUP-4429

Re: Puppet command line tools accept partial matches for flags without altering behavior We should consider this ticket in any plans to work on the puppet CLI.

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg assigned an issue to Unassigned

Puppet / PUP-4429

Puppet command line tools accept partial matches for flags without altering behavior

Change By: Kylo Ginsberg Assignee: Kylo Ginsberg

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Henrik Lindberg

The Puppet command line tools will accept partial matches for flags, but do not use the values provided. This causes unexpected behavior when a command accepts a flag or type but doesn't actually act upon it.

h2. Reproduction Case

Install Puppet 3.7.x or 4.0.x.

Execute {{config print}} commands with flags that affect settings, such as {{puppet agent  \  --no-daemonize  \  --configprint daemonize}} with various truncations of the {{ \ --no-daemonize}} flag. h3. Outcome

Partial matches are accepted, but don't alter the setting value:

{noformat}

puppet agent --no-daemon --configprint daemonize true puppet agent --no-daemoniz --configprint daemonize true # Correct behavior when flag is fully specified. puppet agent --no-daemonize --configprint daemonize false

{noformat} h3. Expected Outcome

The Puppet command line interface should treat partial flags the same way as missing flags and throw an 'invalid option' error:

{noformat}

puppet agent --no-daemon Error: Could not parse application options: invalid option: --no-daemon

{noformat}

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Josh Cooper Fix Version/s: PUP 4.x

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Kylo Ginsberg Labels: cli  redmine

Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Kylo Ginsberg Component/s: CLI

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Josh Cooper Fix Version/s: PUP 4.y Fix Version/s: PUP 5.y

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Rob Browning (JIRA)]

Rob Browning updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Rob Browning Team: Agent

Add Comment

[Rob Browning (JIRA)]

Rob Browning updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Rob Browning Labels: redmine  triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-4429 Puppet command line tools accept partial matches for flags without altering behavior

Change By: Moses Mendoza Labels: redmine  triaged

Add Comment

[Charlie Sharpsteen (Jira)]

Charlie Sharpsteen commented on PUP-4429

Re: Puppet command line tools accept partial matches for flags without altering behavior Still an issue with Puppet 7.18.0.

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Charlie Sharpsteen (Jira)]

Charlie Sharpsteen updated an issue

Puppet / PUP-4429

Puppet command line tools accept partial matches for flags without altering behavior

Change By: Charlie Sharpsteen Affects Version/s: PUP 7.18.0

Add Comment