Jira (PUP-3907) Noop changes to file ownership fail if required User or Group does not exist

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen created an issue

Puppet / PUP-3907 Noop changes to file ownership fail if required User or Group does not exist Issue Type: Bug Affects Versions: PUP 3.7.3 Assignee: Kylo Ginsberg Components: Catalog Application Created: 2015/01/23 12:11 PM Priority: Normal Reporter: Charlie Sharpsteen If a noop run contains File resources, and those resources have pending changes for User or Group ownership, the run will show failures if those User or Group resources don't exist yet. Reproduction Case Create the following manifest: # noop_test.pp file {'/tmp/usertest': ensure => present, owner => testuser, }   file {'/tmp/grouptest': ensure => present, group => testgroup, }   user{'testuser': ensure => present, }   group{'testgroup': ensure => present, } Create the test file: touch /tmp/usertest touch /tmp/grouptest Outcome A noop application produces errors: # puppet apply --noop noop_test.pp   Notice: Compiled catalog for poss-head-master.puppetdebug.vlan in environment production in 1.87 seconds Notice: /Stage[main]/Main/User[testuser]/ensure: current_value absent, should be present (noop) Error: Could not find user testuser Error: /Stage[main]/Main/File[/tmp/usertest]/owner: change from root to testuser failed: Could not find user testuser Notice: /Stage[main]/Main/Group[testgroup]/ensure: current_value absent, should be present (noop) Error: Could not find group testgroup Error: /Stage[main]/Main/File[/tmp/grouptest]/group: change from root to testgroup failed: Could not find group testgroup Notice: Applied catalog in 0.08 seconds Expected Outcome The noop run notes that the values would be changed but doesn't produce an error. The error should only happen if Users or Groups are missing when Puppet enforces the change. Add Comment

This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-3907

Noop changes to file ownership generate failures if required User or Group does not exist Change By: Charlie Sharpsteen Summary: Noop changes to file ownership  fail  generate failures  if required User or Group does not exist

Add Comment

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Maggie Dreyer Labels: noop

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Sean McDonald (JIRA)]

Sean McDonald assigned an issue to Unassigned

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Sean McDonald Assignee: Kylo Ginsberg

Add Comment

[Sean McDonald (JIRA)]

Sean McDonald updated an issue

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Sean McDonald Team: Agent

Add Comment

[Sean McDonald (JIRA)]

Sean McDonald updated an issue

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Sean McDonald Labels: noop  triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Moses Mendoza Labels: noop  triaged

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Josh Cooper Fix Version/s: PUP 7.13.0

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-3907 Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Josh Cooper Sprint: Coremunity Kanban

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-3907

Re: Noop changes to file ownership generate failures if required User or Group does not exist The error occurs because puppet tries to normalize the user and group name to uid/gid in order to determine if the file owner & group are insync or not. And it doesn't take noop into account before raising. Its possible to avoid this by specify the uid & gid for the user and group resources, but there seems to be a trivial fix here.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-3907

Re: Noop changes to file ownership generate failures if required User or Group does not exist

Merged to main in https://github.com/puppetlabs/puppet/commit/b41d8e5d6ee0ab274f5ae298ad01868941c24400

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-3907

Noop changes to file ownership generate failures if required User or Group does not exist

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Puppet will now correctly report when a file's owner or group would change in noop mode even if the owner or group would be created in the same run.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-3907

Re: Noop changes to file ownership generate failures if required User or Group does not exist Passed CI in fb4a1dc506

Add Comment