Jira (HI-307) cleanup dns-alt-names setting and CLI option

12 views
Skip to first unread message

Henrik Lindberg (JIRA)

unread,
Jan 13, 2015, 11:40:21 AM1/13/15
to puppe...@googlegroups.com
Henrik Lindberg created an issue
 
Hiera / Task HI-307
cleanup dns-alt-names setting and CLI option
Issue Type: Task Task
Assignee: Unassigned
Created: 2015/01/13 8:40 AM
Priority: Normal Normal
Reporter: Henrik Lindberg

See PUP-3684 for background.

Basically, there are two settings/options that affect the same setting; --dns-alt-names, and --dns_alt_names. In order to unite the two with the same setting riority, there is the need to have a method in settings that allows patching of the CLI provided value. This method was renamed from set_value (a deprecated method) to patch_value a non deprecated method that is marked as private.

The task is to get rid of this horrible construct by deprecating the unwanted form of --dns-alt-names and updating the code.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Jan 13, 2015, 11:41:21 AM1/13/15
to puppe...@googlegroups.com
Henrik Lindberg moved an issue
 
Puppet / Improvement PUP-3836
Change By: Henrik Lindberg
Issue Type: Task Improvement
Key: HI PUP - 307 3836
Project: Hiera Puppet

Henrik Lindberg (JIRA)

unread,
Jan 13, 2015, 11:42:22 AM1/13/15
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Jan 13, 2015, 11:42:23 AM1/13/15
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 4.x

Henrik Lindberg (JIRA)

unread,
Feb 21, 2016, 7:49:02 PM2/21/16
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-3836
 
Re: cleanup dns-alt-names setting and CLI option

Ping Kylo Ginsberg and Chris Price - this is a golden oldie and was left over in the 4.0.0 code removal. I am not sure where this belongs. As the description says: See

PUP-3684 for background.
This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Sep 7, 2016, 6:12:23 PM9/7/16
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Team: Puppet Developer Support
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Apr 25, 2017, 6:13:02 AM4/25/17
to puppe...@googlegroups.com
 
Re: cleanup dns-alt-names setting and CLI option

Ping Eric Sorenson - this is now more than a "golden oldie"...

Henrik Lindberg (JIRA)

unread,
May 15, 2017, 3:38:02 PM5/15/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
See PUP-3684 for background.

Basically, there are two settings/options that affect the same setting; --dns-alt-names, and --dns_alt_names. In order to unite the two with the same setting
 riority  priority , there is the need to have a method in settings that allows patching of the CLI provided value. This method was renamed from {{set_value}} (a deprecated method) to {{patch_value}} a non deprecated method that is marked as private.


The task is to get rid of this horrible construct by deprecating the unwanted form of --dns-alt-names and updating the code.

Henrik Lindberg (JIRA)

unread,
May 15, 2017, 3:38:02 PM5/15/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 4.y
Fix Version/s: PUP 5.y

Henrik Lindberg (JIRA)

unread,
May 15, 2017, 3:39:03 PM5/15/17
to puppe...@googlegroups.com

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:49:40 PM5/18/17
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Mar 13, 2020, 6:46:02 PM3/13/20
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-3836
 
Re: cleanup dns-alt-names setting and CLI option

This is no longer an issue because the puppet cert CLI is non-functional, so --dns-alt-names is never acceped as a CLI option in puppet or the puppetserver-ca-cli repo, so I'm going to close this as won't fix.

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages