Jira (FACT-3207) Don't rescue NoMethodError

[Josh Cooper (Jira)]

Josh Cooper created an issue

Facter / FACT-3207 Don't rescue NoMethodError Issue Type: Bug Assignee: Unassigned Created: 2023/06/06 8:10 AM Priority: Normal Reporter: Josh Cooper The base resolver rescues NoMethodError, which hides bugs in resolvers. For example, if I disable the rescue, exposing a bug in the dmi resolver: $ bundle exec facter --debug [2023-06-06 08:07:21.541262 ] DEBUG Facter::Resolvers::Linux::DmiBios - Resolving fact product_serial, but got undefined method `encode' for nil:NilClass   .encode('UTF-8', invalid: :replace) ^^^^^^^ at /home/josh/work/facter/lib/facter/resolvers/dmi.rb:39:in `read_facts' Add Comment

This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3207 Don't rescue NoMethodError

Change By: Josh Cooper The base resolver rescues NoMethodError, which hides bugs in resolvers. For example, if I disable the rescue, exposing it exposes a bug in the dmi resolver: {noformat}

$ bundle exec facter --debug [2023-06-06 08:07:21.541262 ] DEBUG Facter::Resolvers::Linux::DmiBios - Resolving fact product_serial, but got undefined method `encode' for nil:NilClass                      .encode('UTF-8', invalid: :replace)                      ^^^^^^^ at /home/josh/work/facter/lib/facter/resolvers/dmi.rb:39:in `read_facts'

{noformat}

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3207 Don't rescue NoMethodError

Change By: Michael Hashizume Epic Link: PUP-11660

Add Comment