Jira (PUP-11787) Warn if puppet falls back to PSON

11 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Mar 23, 2023, 6:31:02 PM3/23/23
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-11787
Warn if puppet falls back to PSON
Issue Type: Task Task
Assignee: Unassigned
Created: 2023/03/23 3:30 PM
Priority: Normal Normal
Reporter: Josh Cooper

If puppet's indirected routes handler attempts to render a model, e.g. catalog, but it fails, log a warning that fallback is occurring. Currently we log a message at debug which doesn't help anyone:

https://github.com/puppetlabs/puppet/blob/10f53856a0e905c8d9deb4bf9abbc99b129a3d66/lib/puppet/network/http/api/indirected_routes.rb#L195

It should be replaced with something like this. It's important to capture the name/key so we know which hosts' catalog is causing the issue:

      rescue Puppet::Network::FormatHandler::FormatError => err
        Puppet.warning("Failed to serialize #{model} for #{key} to #{format}")
        false
      end

Later, we'll introduce a setting to disable fallback PUP-10928.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Mar 23, 2023, 6:32:02 PM3/23/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Priority: Normal High

Josh Cooper (Jira)

unread,
Mar 23, 2023, 6:32:02 PM3/23/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-11659

Josh Cooper (Jira)

unread,
Mar 23, 2023, 6:32:02 PM3/23/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Phoenix

Josh Cooper (Jira)

unread,
Mar 24, 2023, 6:51:01 PM3/24/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2023-03-29

Josh Cooper (Jira)

unread,
Mar 24, 2023, 6:51:01 PM3/24/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Story Points: 1

Josh Cooper (Jira)

unread,
Mar 24, 2023, 6:51:02 PM3/24/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.24.0

Josh Cooper (Jira)

unread,
Mar 24, 2023, 6:54:01 PM3/24/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Enhancement
Release Notes Summary: Puppetserver will now log a warning instead of debug message if it fails to serialize a catalog and falls back to PSON, which usually occurs when binary data is present in the catalog.

Parker Leach (Jira)

unread,
Apr 5, 2023, 5:52:04 PM4/5/23
to puppe...@googlegroups.com
Parker Leach updated an issue
Change By: Parker Leach
Labels: docs_reviewed
Reply all
Reply to author
Forward
0 new messages