Jira (FACT-3184) Switch to relative_require

1 view
Skip to first unread message

Josh Cooper (Jira)

unread,
Feb 10, 2023, 1:01:02 PM2/10/23
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Facter / Task FACT-3184
Switch to relative_require
Issue Type: Task Task
Assignee: Unassigned
Created: 2023/02/10 10:00 AM
Priority: Normal Normal
Reporter: Josh Cooper

Facter 4 should use relative_require not require for most cases where we're loading facter implementation code and not extensions. Using "require" is extremely slow on Windows, because of the way Ruby scans the LOAD_PATH. Effectively for each directory in the load path, Ruby determines its "realpath" which results in file I/O to open the directory and all of its ancestors, and repeating.

I noticed this when researching PA-4911

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Feb 16, 2023, 12:21:04 AM2/16/23
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (Jira)

unread,
Mar 2, 2023, 6:20:01 PM3/2/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Story Points: 2

Josh Cooper (Jira)

unread,
Mar 2, 2023, 8:51:02 PM3/2/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2023-03-15

Josh Cooper (Jira)

unread,
Mar 15, 2023, 2:30:05 PM3/15/23
to puppe...@googlegroups.com

Michael Hashizume (Jira)

unread,
Mar 29, 2023, 1:08:05 PM3/29/23
to puppe...@googlegroups.com
Michael Hashizume updated an issue
Change By: Michael Hashizume
Sprint: Phoenix 2023-04-12

Josh Cooper (Jira)

unread,
Apr 13, 2023, 12:39:02 PM4/13/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Enhancement
Release Notes Summary: Facter now uses "require_relative" instead of "require"

Parker Leach (Jira)

unread,
Apr 19, 2023, 3:14:02 PM4/19/23
to puppe...@googlegroups.com
Parker Leach updated an issue
Change By: Parker Leach
Labels: docs_reviewed
Reply all
Reply to author
Forward
0 new messages