Jira (PUP-11717) Can't "dig" into facts when legacy facts are excluded

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded Issue Type: Task Assignee: Unassigned Created: 2023/01/16 9:36 PM Fix Versions: 7.22.0 Priority: Normal Reporter: Josh Cooper If legacy facts are disabled, then the $facts variable will refer to an instance of Facter::FactCollection, which subclasses Hash, rather than a Hash instance. See FACT-3179. When attempting to dig into facts, e.g. $facts.dig('..'), then the dig function will fail, because the function expects a Collection not a Runtime: $ puppet apply -e '$facts.dig("ruby")' --no-include_legacy_facts Error: Evaluation Error: Error while evaluating a Method call, 'dig' parameter 'data' expects a value of type Undef or Collection, got Runtime (line: 1, column: 11) on node localhost Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper Team: Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper Story Points: 2

Add Comment

[Morgan Rhodes (Jira)]

Morgan Rhodes updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Morgan Rhodes Sprint: Phoenix 2023-02-01

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper Epic Link: PUP-11658

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Ben Ford (Jira)]

Ben Ford commented on PUP-11717

Re: Can't "dig" into facts when legacy facts are excluded The PR looks like it also protects fact() from breaking, but maybe worth a quick check.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11717

Re: Can't "dig" into facts when legacy facts are excluded

Looks like it's ok: ❯ bx puppet --version 7.21.0 ❯ bx puppet apply -e 'notice(fact("ruby.version"))' --no-include_legacy_facts Notice: Scope(Class[main]): 2.7.6 Notice: Compiled catalog for localhost in environment production in 0.01 seconds Notice: Applied catalog in 0.04 seconds The dig function is a little unique in that it requires a Collection parameter, so it triggers the issue. I'm not sure how many user function do that level of type checking, but I'm sure someone is.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11717

Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper If legacy facts are disabled (PUP-11662) , then the {{$facts}} variable will refer to an instance of {{ {} Facter::FactCollection { }} } , which subclasses {{ {} Hash { }} } , rather than a {{Hash}} instance. See FACT-3179. When attempting to dig into facts, e.g. {{ {} $facts.dig('..') { }} } , then the dig function will fail, because the [function expects a {{Collection}}|https://github.com/puppetlabs/puppet/blob/7f96b47f8419ad95509552f75690fad957fb97a9/lib/puppet/functions/dig.rb#L32] not a {{ {} Runtime { }} } : {noformat}

$ puppet apply -e '$facts.dig("ruby")' --no-include_legacy_facts Error: Evaluation Error: Error while evaluating a Method call, 'dig' parameter 'data' expects a value of type Undef or Collection, got Runtime (line: 1, column: 11) on node localhost

{noformat}

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Catalog compilation no longer fails when using the "dig" function and excluding legacy facts.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Josh Cooper Fix Version/s: PUP 7.23.0

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Puppet / PUP-11717 Can't "dig" into facts when legacy facts are excluded

Change By: Parker Leach Labels: docs_reviewed

Add Comment