Jira (PUP-3062) The default unit for `splaylimit` should not be seconds.

2 views
Skip to first unread message

Owen Rodabaugh (JIRA)

unread,
Jul 9, 2015, 6:52:15 PM7/9/15
to puppe...@googlegroups.com
Owen Rodabaugh updated an issue
 
Puppet / Improvement PUP-3062
The default unit for `splaylimit` should not be seconds.
Change By: Owen Rodabaugh
CS Priority: Reviewed
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
Atlassian logo

Rob Lucke (JIRA)

unread,
May 16, 2017, 3:32:03 PM5/16/17
to puppe...@googlegroups.com
Rob Lucke updated an issue
Change By: Rob Lucke
Labels: customer  help_wanted  support  triaged
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:49:27 PM5/18/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: customer help_wanted support  triaged

Nick Walker (JIRA)

unread,
May 22, 2017, 4:34:02 PM5/22/17
to puppe...@googlegroups.com
Nick Walker commented on Improvement PUP-3062
 
Re: The default unit for `splaylimit` should not be seconds.

I agree that the only correct way to implement this change if we decide to do so is to error out if the unit is not specified instead of silently changing users splay to minutes when they now expect seconds.

Josh Cooper (JIRA)

unread,
Mar 29, 2019, 6:11:05 PM3/29/19
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Team: Coremunity
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Jun 19, 2019, 1:38:04 PM6/19/19
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-3062
 
Re: The default unit for `splaylimit` should not be seconds.

The runinterval and splaylimit settings are both type duration. If you set either of them and don't specify units, then they both are interpreted as seconds. The reason this issue occurred is because runinterval defaults to 30m, but splaylimit was overridden as 60 which is interpreted as seconds.

I don't think requiring units is a good idea. It would be very disruptive without a lot of benefit, as everything that has ever set a puppet setting would need to be aware of units, such as puppet config set runinterval 30m, packaging (rpm, deb, msi), cloud-init scripts, kickstart, foreman, etc.

Closing this ticket.

Reply all
Reply to author
Forward
0 new messages