Jira (FACT-3175) Remove sys-filesystem monkey patch

6 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jan 6, 2023, 3:41:03 PM1/6/23
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Facter / Task FACT-3175
Remove sys-filesystem monkey patch
Issue Type: Task Task
Assignee: Unassigned
Created: 2023/01/06 12:40 PM
Priority: Normal Normal
Reporter: Josh Cooper

Facter monkey patches sys-filesystem due to FACT-2782. See https://github.com/puppetlabs/facter/commit/50e2d8fb8aba9fd775342f622f663b2f23161827

The fix was submitted upstream and merged (see https://github.com/djberg96/sys-filesystem/commit/47c0045e529fb7254e88e4167c66d5818763d18c), so we should be able to:

1. bump our minimum gem dependency in https://github.com/puppetlabs/facter/blob/main/facter.gemspec#L38

2. Remove the monkey patch from facter

3. Bump the sys-filesystem gem in puppet-runtime (for both agent-runtime-7.x and agent-runtime-main) see https://github.com/puppetlabs/puppet-runtime/blob/master/configs/components/rubygem-sys-filesystem.rb

This should be fixed in both 7.x and main
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Morgan Rhodes (Jira)

unread,
Jan 10, 2023, 4:15:01 PM1/10/23
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Team: Phoenix

Morgan Rhodes (Jira)

unread,
Jan 10, 2023, 4:15:03 PM1/10/23
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Epic Link: PUP-11659
Reply all
Reply to author
Forward
0 new messages