Jira (PUP-11691) Provide setting to report non-versioned path to resource when using versioned dirs

35 views
Skip to first unread message

Justin Stoller (Jira)

unread,
Dec 14, 2022, 4:02:03 PM12/14/22
to puppe...@googlegroups.com
Justin Stoller created an issue
 
Puppet / Improvement PUP-11691
Provide setting to report non-versioned path to resource when using versioned dirs
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2022/12/14 1:01 PM
Priority: Normal Normal
Reporter: Justin Stoller

In PUP-10255 we added the ability to readlink symlinks within the environmentpath. This causes resources to report the full non-symlinked path as their location in the catalog and report. Now, when using versioned dirs, whenever a new code deployment happens that full path changes (because it contains the environment version in the path). This causes a lot of unnecessary churn in catalogs and reports because even unchanged resources look like they come from a different path.

We should enable the ability for a resource to report itself as coming from the symlinked path rather than the full path after readlinking. This ability should be behind a configuration flag and default to off.

 

NB.

This maybe be possible by editing how the source locator in the parser reports what file a resource it created came from. Though, if resources take that file information and try to access the disk themselves (eg, in a create_resources like step) then we may not be able to do so.

Another route may be to post process the catalog and adjust the every resource to use the original symlinked env path.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Justin Stoller (Jira)

unread,
Dec 14, 2022, 5:23:01 PM12/14/22
to puppe...@googlegroups.com
Justin Stoller commented on Improvement PUP-11691
 
Re: Provide setting to report non-versioned path to resource when using versioned dirs

Josh Cooper , Austin Blatt , Nick Burgan this is the work for option #2 in the linked PE escalation.

I think we can ship this in the next agent release and then give folks encountering this (and not using CD4PE) a path forward. We can then release a toggle in the next PE release for easier usage. Once CD4PE can use this we can default to having it on. I think Nick was working with Product to prioritize and get the work distributed to the correct teams, and Austin was coordinating from a technical side (and had already talked to CD4PE). Are those assumptions correct?

Morgan Rhodes (Jira)

unread,
Jan 10, 2023, 4:44:01 PM1/10/23
to puppe...@googlegroups.com

Morgan Rhodes (Jira)

unread,
Jan 10, 2023, 4:44:03 PM1/10/23
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Jan 16, 2023, 6:37:03 PM1/16/23
to puppe...@googlegroups.com
 
Re: Provide setting to report non-versioned path to resource when using versioned dirs

Some notes:

  • We should start by looking into the parser/locator approach and fallback to the post processing/serialization if that doesn't work out.
  • We need to coordinate the control of this behavior with consumers like CD4PE and may need to add a separate setting to manage whether or not versioned_dirs are reported or the symlink dir is reported.

Morgan Rhodes (Jira)

unread,
Jan 18, 2023, 1:41:02 PM1/18/23
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Jan 23, 2023, 5:33:03 PM1/23/23
to puppe...@googlegroups.com

David Piekny (Jira)

unread,
Jan 24, 2023, 3:46:03 PM1/24/23
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jan 24, 2023, 8:28:04 PM1/24/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.22.0
Fix Version/s: PUP 7.23.0

Josh Cooper (Jira)

unread,
Jan 24, 2023, 8:28:04 PM1/24/23
to puppe...@googlegroups.com

Cas Donoghue (Jira)

unread,
Jan 26, 2023, 2:59:03 PM1/26/23
to puppe...@googlegroups.com

Cas Donoghue (Jira)

unread,
Jan 26, 2023, 3:00:03 PM1/26/23
to puppe...@googlegroups.com

Cas Donoghue (Jira)

unread,
Feb 1, 2023, 1:22:03 PM2/1/23
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Feb 8, 2023, 4:46:02 PM2/8/23
to puppe...@googlegroups.com

Cas Donoghue (Jira)

unread,
Feb 15, 2023, 1:23:02 PM2/15/23
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Sprint: Skeletor 02/15/2023 , Skeletor 03/01/2024

Justin Stoller (Jira)

unread,
Feb 24, 2023, 12:13:03 PM2/24/23
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Mar 9, 2023, 5:57:01 PM3/9/23
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Mar 10, 2023, 12:13:04 PM3/10/23
to puppe...@googlegroups.com
Justin Stoller updated an issue

Added Release notes.

Change By: Justin Stoller
Release Notes: Enhancement
Release Notes Summary: When the "versioned_environment_dirs" setting is enabled Puppet would previously report the full directory path to the environment *after* resolving symlinks as the source for resources in a catalog.

Puppet will now report the path to the resource *before* resolving symlinks in the "environmentpath". Users may revert to the previous behavior by setting the new configuration option "report_configured_environmentpath" to false.

Ingrida Cazers (Jira)

unread,
Apr 10, 2023, 5:28:02 PM4/10/23
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages