Jira (PUP-11661) Preserve noop-ness when unchanged resources are omitted

9 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Oct 20, 2022, 1:49:02 PM10/20/22
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-11661
Preserve noop-ness when unchanged resources are omitted
Issue Type: Task Task
Assignee: Unassigned
Created: 2022/10/20 10:48 AM
Priority: Normal Normal
Reporter: Josh Cooper

In PUP-11654, we're adding a setting to not send unchanged resource statuses. However, some fields in the report are derived from resource statuses and events. For example, the corrective_change and noop_pending instance variables are computed in the finalize_report method. If a report is deserialized using Report.from_data_report and then re-serialized using Report#to_data_hash, it's important that the original corrective_change and noop_pending data be preserved. I believe it will work that way, but it's something to check.

Another complication is the puppetdb report processor determines if a report to be "noop" based on events. So we may need to include unchanged events that were explicitly marked as "noop".

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Morgan Rhodes (Jira)

unread,
Oct 26, 2022, 1:36:03 PM10/26/22
to puppe...@googlegroups.com

Morgan Rhodes (Jira)

unread,
Oct 26, 2022, 1:36:03 PM10/26/22
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Sprint: Phoenix 2022-11-23

Morgan Rhodes (Jira)

unread,
Nov 9, 2022, 1:43:01 PM11/9/22
to puppe...@googlegroups.com

Tony Vu (Jira)

unread,
Nov 17, 2022, 12:11:02 PM11/17/22
to puppe...@googlegroups.com

Christopher Thorn (Jira)

unread,
Nov 23, 2022, 1:06:02 PM11/23/22
to puppe...@googlegroups.com
Christopher Thorn updated an issue
Change By: Christopher Thorn
Sprint: Phoenix 2022-11-23 , Phoenix 2022-12-7

Aria Li (Jira)

unread,
Nov 30, 2022, 8:01:03 PM11/30/22
to puppe...@googlegroups.com
Aria Li updated an issue
Change By: Aria Li
Fix Version/s: PUP 7.21.0

Tony Vu (Jira)

unread,
Dec 1, 2022, 5:29:02 PM12/1/22
to puppe...@googlegroups.com
Tony Vu commented on Task PUP-11661
 
Re: Preserve noop-ness when unchanged resources are omitted

The implementation change of PUP-11654 makes the first two concerns about corrective_change and noop_pending not applicable; it will not affect those instance variables reading in from initialize_from_hash and to_data_hash.

noop is sent as a top level field in the testing that I have done, so I don't think that we will hit that cod path Josh Cooper linked to; if we do hit that code path, there is a possibility that noop evaluating to false falsely might occur.

Reply all
Reply to author
Forward
0 new messages