Jira (FACT-3155) Remove timecop from spec tests

13 views
Skip to first unread message

Michael Hashizume (Jira)

unread,
Oct 6, 2022, 5:17:01 PM10/6/22
to puppe...@googlegroups.com
Michael Hashizume created an issue
 
Facter / Task FACT-3155
Remove timecop from spec tests
Issue Type: Task Task
Assignee: Unassigned
Created: 2022/10/06 2:16 PM
Priority: Normal Normal
Reporter: Michael Hashizume

timecop was added as spec dependency in Facter for a specific AWS-related test: https://github.com/puppetlabs/facter/commit/8c323415a59025232fc06e1dc5853e10c5ee8a32

However, we've recently run into an issue while testing Ruby 3.2.0 preview releases because of how timecop interacts with Psych: https://github.com/travisjeffery/timecop/issues/390

We should deprecate timecop from the AWS test to reduce our external dependencies.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Morgan Rhodes (Jira)

unread,
Oct 11, 2022, 4:26:01 PM10/11/22
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Epic Link: PA-4664

Morgan Rhodes (Jira)

unread,
Oct 11, 2022, 4:27:03 PM10/11/22
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Story Points: 3

Josh Cooper (Jira)

unread,
Jan 30, 2023, 7:47:02 PM1/30/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2023-02-15

Aria Li (Jira)

unread,
Feb 8, 2023, 4:13:02 PM2/8/23
to puppe...@googlegroups.com
Aria Li assigned an issue to Aria Li
Change By: Aria Li
Assignee: Aria Li

Josh Cooper (Jira)

unread,
Mar 9, 2023, 6:01:01 PM3/9/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Not Needed

Josh Cooper (Jira)

unread,
Mar 21, 2023, 4:54:03 PM3/21/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: FACT 4.3.1
Reply all
Reply to author
Forward
0 new messages