Jira (PUP-11630) puppetlabs-mount_core does not honor remounts on freebsd

4 views
Skip to first unread message

Matt (Jira)

unread,
Sep 23, 2022, 9:42:02 AM9/23/22
to puppe...@googlegroups.com
Matt created an issue
 
Puppet / Bug PUP-11630
puppetlabs-mount_core does not honor remounts on freebsd
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2022/09/23 6:41 AM
Priority: Normal Normal
Reporter: Matt

Puppet Version: 7.15.0
Puppet Server Version: 7.17.0
OS Name/Version: FreeBSD

puppetlabs-mount_core (v1.1.0)

Hello, I'm using FreeBSD and I have the following mount entry,

 

  mount { '/dev/fd':
    ensure => mounted,
    name => '/dev/fd',
    device => 'fdescfs',
    fstype => 'fdescfs',
    options => 'rw',
    remounts => false
  }

 

which fails with the following output,

 

Computing checksum on file /etc/fstab
Scheduling refresh of Mount[/dev/fd]
Mount[/dev/fd](provider=parsed): Remounting
Failed to call refresh: Execution of '/sbin/mount -o rw,update /dev/fd' returned 1: mount: fdescfs: Operation not supported
Execution of '/sbin/mount -o rw,update /dev/fd' returned 1: mount: fdescfs: Operation not supported

 

It looks like remounts => false is not honored on freebsd. The relevant code is in mount.rb, 

 

elsif %r{^(FreeBSD|DragonFly|OpenBSD)$}.match?(os)

which is missing the check for supports_remounts thus incorrectly assuming all of FreeBSD supports "update".

Desired Behavior:

the mount should succeed

Actual Behavior:

mount fails due to the incorrect update parameter

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Michael Hashizume (Jira)

unread,
Sep 27, 2022, 4:55:02 PM9/27/22
to puppe...@googlegroups.com
Michael Hashizume commented on Bug PUP-11630
 
Re: puppetlabs-mount_core does not honor remounts on freebsd

Thank you for reporting this issue. While we agree this is likely an improvement, we do not anticipate addressing this any time soon due to other issues demanding precedence. As such, this ticket will be closed as “Won’t Do”. We may revisit this at a later time, and if so, will re-open this ticket.

If you are interested in submitting a patch to implement this issue, please open a pull request and re-open this ticket.

Reply all
Reply to author
Forward
0 new messages