Jira (PDB-5517) Don't fail upgrade_latest acceptance test between tagging and release

[Rob Browning (Jira)]

Rob Browning created an issue

PuppetDB / PDB-5517 Don't fail upgrade_latest acceptance test between tagging and release Issue Type: Improvement Assignee: Unassigned Components: PuppetDB Created: 2022/08/02 1:40 PM Priority: Normal Reporter: Rob Browning Right now upgrade_latest fails between tagging and the actual release because of the way it picks versions.  It stops failing once the new packages are actually available via yum.  Change it to remain green during that period so we don't have to remember we should ignore it. While we may still want a pre-flight check like that to run just before announcing a release, it might belong elsewhere. Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Stel Abrego (Jira)]

Stel Abrego commented on PDB-5517

Re: Don't fail upgrade_latest acceptance test between tagging and release When the test is changed to not fail when (and post-tag? pre-release?), the PDB release ticket templates in tefoji-puppet-templates repo should be changed. In particular this part:       * Check that all the builds are green. The parameterized acceptance tests' upgrade_latest jobs in Jenkins are expected to fail at this point         with an error like:             Error: Could not update: Execution of '/usr/bin/yum -d 0 -e 0 -y install puppetdb-7.11.0-1.el7' returned 1: Error: Nothing to do

Add Comment

[Austin Blatt (Jira)]

Austin Blatt commented on PDB-5517

Re: Don't fail upgrade_latest acceptance test between tagging and release

To do this work we must be able to codify, in beaker tests, the difference between "tagged and pre-release" and "tagged and post-release, but there's no new PuppetDB package available". Identifying, from our CI, whether or not the package should be available publicly is somewhat difficult. Otherwise this test may silently NOT be testing upgrade_latest if the PuppetDB packages are not released. Also random aside, I noticed that folks caught this because they added FOSS PuppetDB tests to the PE CI Triage command ! pipelines for 2019.8.x. If it is a requirement that components have a relevant CI job to track for that command, possibly the correct outcome is for there to be actual PE PuppetDB acceptance tests for the CI triage job to watch. PE 2019.8.x, or other PE version, doesn't actually care how our FOSS PuppetDB packages are performing in their CI.

Add Comment