Jira (PUP-11594) Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

[Clay Caviness (Jira)]

Clay Caviness created an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory Issue Type: Bug Assignee: Unassigned Created: 2022/07/20 9:27 AM Priority: Normal Reporter: Clay Caviness Puppet Version: 7.12.0 Puppet Server Version: N/A OS Name/Version: macOS 12.5 If a host has /proc/self but as a file, safe_posix_fork will throw an unhandled Errno::ENOTDIR, leading to a failed puppet run. This is not typical, but we had a user on a macOS 12 machine set up /proc/self in this way: Append proc Volumes/proc to /etc/synthentic.conf sudo mkdir /Volumes/proc Reboot sudo touch /proc/self Subsequent puppet executions will fail: Error: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: Could not get group list from DirectoryService Error: Could not prepare for execution: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: Could not get group list from DirectoryService Adding Errno::ENOTDIR to the rescue here works around the issue. Desired Behavior: Puppet handles misconfigured /proc filesystems correctly Actual Behavior: Puppet runs fail. $ echo "notice('test')" | sudo /Library/GoogleCorpSupport/bin/puppet apply --test --trace --debug Error: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: Could not get group list from DirectoryService /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:101:in `rescue in list_all_present' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:98:in `list_all_present' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:151:in `single_report' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:504:in `getinfo' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice.rb:192:in `exists?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/type/group.rb:234:in `exists?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:888:in `service_group_available?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:52:in `safe_to_use_settings_value?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:43:in `value' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:95:in `group' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:157:in `to_resource' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1052:in `block in to_catalog' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1048:in `each' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1048:in `to_catalog' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1123:in `use' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/application/apply.rb:310:in `setup' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/application.rb:413:in `block in run' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/util.rb:744:in `exit_on_fail' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/application.rb:413:in `run' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/util/command_line.rb:143:in `run' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/util/command_line.rb:77:in `execute' /Library/GoogleCorpSupport/Puppet/bin/puppet:5:in `<main>' Error: Could not prepare for execution: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: Could not get group list from DirectoryService Could not get group list from DirectoryService /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:101:in `rescue in list_all_present' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:98:in `list_all_present' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:151:in `single_report' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice/directoryservice.rb:504:in `getinfo' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/provider/nameservice.rb:192:in `exists?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/type/group.rb:234:in `exists?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:888:in `service_group_available?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:52:in `safe_to_use_settings_value?' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:43:in `value' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:95:in `group' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings/file_setting.rb:157:in `to_resource' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1052:in `block in to_catalog' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1048:in `each' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1048:in `to_catalog' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/settings.rb:1123:in `use' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/application/apply.rb:310:in `setup' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/application.rb:413:in `block in run' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/util.rb:744:in `exit_on_fail' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/application.rb:413:in `run' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/util/command_line.rb:143:in `run' /Library/GoogleCorpSupport/Puppet/lib/ruby/site_ruby/puppet/util/command_line.rb:77:in `execute' /Library/GoogleCorpSupport/Puppet/bin/puppet:5:in `<main>' Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Clay Caviness (Jira)]

Clay Caviness commented on PUP-11594

Re: Puppet::Util.safe_posix_fork fails if /proc/self is not a directory https://github.com/puppetlabs/puppet/pull/8927 should fix this issue.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11594

Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Josh Cooper Team: Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Josh Cooper Sprint: Phoenix 2022-08-17

Add Comment

[Nirupama Mantha (Jira)]

Nirupama Mantha updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Nirupama Mantha Story Points: 1

Add Comment

[Tony Vu (Jira)]

Tony Vu updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Tony Vu Sprint: Phoenix 2022-08- 17 03

Add Comment

[Tony Vu (Jira)]

Tony Vu assigned an issue to Tony Vu

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Tony Vu Assignee: Tony Vu

Add Comment

[Nirupama Mantha (Jira)]

Nirupama Mantha updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Nirupama Mantha Sprint: Phoenix 2022-08-03 , Phoenix 2022-08-17

Add Comment

[Lisa Ross (Jira)]

Lisa Ross updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Lisa Ross

Sprint: Phoenix 2022-08-03 , Phoenix 2022-08-17

Add Comment

[Lisa Ross (Jira)]

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11594

Re: Puppet::Util.safe_posix_fork fails if /proc/self is not a directory Passed CI in 13188f1cb4

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11594

Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Josh Cooper Fix Version/s: PUP 7.19.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary:

Puppet handles misconfigured /proc filesystems correctly

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Puppet / PUP-11594 Puppet::Util.safe_posix_fork fails if /proc/self is not a directory

Change By: Parker Leach Labels: docs_reviewed

Add Comment