Jira (PUP-11543) templatewrapper.rb deprecation warnings on Ruby 3.1

unread,

May 24, 2022, 4:34:01 PM5/24/22

to puppe...@googlegroups.com

Josh Cooper updated an issue

Change By:	Josh Cooper
Summary:	templatewrapper.rb deprecation warnings on Ruby 3.1

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

unread,

May 26, 2022, 12:03:02 AM5/26/22

to puppe...@googlegroups.com

Josh Cooper commented on

ERB added the trim_mode keyword argument in ruby 2.6.0: https://github.com/ruby/ruby/commit/cc777d09f44fa909a336ba14f3aa802ffe16e010 If we drop 2.6 support, then we can switch to the keyword argument everywhere. Otherwise, we'll need to choose between positional and keyword args.

unread,

Aug 8, 2022, 8:15:01 PM8/8/22

to puppe...@googlegroups.com

Josh Cooper commented on

There's a PR up for PUP-11552 so closing this. The PR should fix ERB warnings coming from templatewrapper and other places in the puppet repo.

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

Reply all

Reply to author

Forward