Jira (PUP-11543) templatewrapper.rb depreciation warnings

[Gene Liverman (Jira)]

Gene Liverman created an issue

Puppet / PUP-11543 templatewrapper.rb depreciation warnings Issue Type: Bug Affects Versions: PUP 7.16.0 Assignee: Unassigned Attachments: image-2022-05-23-22-57-31-397.png Created: 2022/05/23 8:10 PM Environment: $ bundle exec facter os {   architecture => "x86_64",   distro => {     codename => "Thirty Six",     description => "Fedora release 36 (Thirty Six)",     id => "Fedora",     release => {       full => "36",       major => "36"     }   },   family => "RedHat",   hardware => "x86_64",   name => "Fedora",   release => {     full => "36",     major => "36"   },   selinux => {     config_mode => "enforcing",     config_policy => "targeted",     current_mode => "enforcing",     enabled => true,     enforced => true,     policy_version => "33"   } }   $ bundle exec puppet --version 7.16.0   $ ruby --version ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux] Priority: Medium Reporter: Gene Liverman Puppet Version: 7.16.0 (gem) Puppet Server Version: n/a OS Name/Version: Fedora 36 Describe your issue in as much detail as possible… When running spec tests on https://github.com/voxpupuli/puppet-falco via bundler, this line floods my terminal: /home/gene/repos/puppet-falco/vendor/bundle/ruby/3.1.0/gems/puppet-7.16.0/lib/puppet/parser/templatewrapper.rb:93: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead. Here is a screenshot of part of my terminal: Describe steps to reproduce… Clone https://github.com/voxpupuli/puppet-falco run "bundle install --path vendor/bundle" on Fedora 36 with stock ruby run "bundle exec rake spec" Desired Behavior: The indicated error should be resolved so that it is not spewing warnings Actual Behavior: See above for actual. For what it's worth, I did a quick check for the mentioned code that is in need of reformatting and got what is shown below. Note there are multiple places in puppet with the mentioned method signature in addition to places in gems owned by Puppet. $ grep -R 'ERB.new' . ./vendor/bundle/ruby/3.1.0/gems/thor-1.2.1/lib/thor/actions/file_manipulation.rb:          CapturableERB.new(::File.binread(source), :trim_mode => "-", :eoutvar => "@output_buffer") ./vendor/bundle/ruby/3.1.0/gems/thor-1.2.1/lib/thor/actions/file_manipulation.rb:          CapturableERB.new(::File.binread(source), nil, "-", "@output_buffer") ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/Changelog.md:* PR #231 - Deprecate safe_level of ERB.new in Ruby 2.6 (@koic) ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/lib/highline/list_renderer.rb:          ERB.new(item, trim_mode: "%") ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/lib/highline/list_renderer.rb:          ERB.new(item, nil, "%") ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/lib/highline/question.rb:          ERB.new(confirm, trim_mode: "%") ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/lib/highline/question.rb:          ERB.new(confirm, nil, "%") ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/lib/highline/statement.rb:        ERB.new(template_string, trim_mode: "%") ./vendor/bundle/ruby/3.1.0/gems/highline-2.0.3/lib/highline/statement.rb:        ERB.new(template_string, nil, "%") ./vendor/bundle/ruby/3.1.0/gems/simplecov-html-0.10.2/lib/simplecov-html.rb:        ERB.new(File.read(File.join(File.dirname(__FILE__), "../views/", "#{name}.erb"))) ./vendor/bundle/ruby/3.1.0/gems/webrick-1.7.0/lib/webrick/httpservlet/erbhandler.rb:          res.body = evaluate(ERB.new(data), req, res) ./vendor/bundle/ruby/3.1.0/gems/rgen-0.9.0/lib/rgen/metamodel_builder/builder_extensions.rb:      @@one_read_builder ||= ERB.new <<-CODE ./vendor/bundle/ruby/3.1.0/gems/rgen-0.9.0/lib/rgen/metamodel_builder/builder_extensions.rb:      @@one_write_builder ||= ERB.new <<-CODE ./vendor/bundle/ruby/3.1.0/gems/rgen-0.9.0/lib/rgen/metamodel_builder/builder_extensions.rb:      @@many_read_builder ||= ERB.new <<-CODE ./vendor/bundle/ruby/3.1.0/gems/rgen-0.9.0/lib/rgen/metamodel_builder/builder_extensions.rb:      @@many_write_builder ||= ERB.new <<-CODE ./vendor/bundle/ruby/3.1.0/gems/rgen-0.9.0/lib/rgen/metamodel_builder/builder_extensions.rb:    @@derived_builder ||= ERB.new <<-CODE ./vendor/bundle/ruby/3.1.0/gems/rgen-0.9.0/lib/rgen/template_language/template_container.rb:                ERB.new(fileContent,nil,nil,'@output').result(binding) ./vendor/bundle/ruby/3.1.0/gems/ruby-ll-2.1.2/lib/ll/code_generator.rb:      erb      = ERB.new(template, nil, '-').result(context.get_binding) ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/configuration_options.rb:          ERB.new(File.read(path), :trim_mode => '-').result(binding) ./vendor/bundle/ruby/3.1.0/gems/rspec-core-3.11.0/lib/rspec/core/configuration_options.rb:          ERB.new(File.read(path), nil, '-').result(binding) ./vendor/bundle/ruby/3.1.0/gems/facter-4.2.9/lib/docs/generate.rb:          ERB.new(File.read(PATH_TO_TEMPLATE), trim_mode: '-') ./vendor/bundle/ruby/3.1.0/gems/facter-4.2.9/lib/docs/generate.rb:          ERB.new(File.read(PATH_TO_TEMPLATE), nil, '-') ./vendor/bundle/ruby/3.1.0/gems/facter-4.2.9/lib/facter/framework/cli/cli.rb:      erb = ERB.new(File.read(template), nil, '-') ./vendor/bundle/ruby/3.1.0/gems/commander-4.6.0/lib/commander/help_formatters/terminal.rb:          ERB.new(File.read(File.join(File.dirname(__FILE__), 'terminal', "#{name}.erb")), nil, '-') ./vendor/bundle/ruby/3.1.0/gems/commander-4.6.0/lib/commander/help_formatters/terminal.rb:          ERB.new(File.read(File.join(File.dirname(__FILE__), 'terminal', "#{name}.erb")), trim_mode: '-') ./vendor/bundle/ruby/3.1.0/gems/commander-4.6.0/lib/commander/help_formatters/terminal_compact.rb:          ERB.new(File.read(File.join(File.dirname(__FILE__), 'terminal_compact', "#{name}.erb")), nil, '-') ./vendor/bundle/ruby/3.1.0/gems/commander-4.6.0/lib/commander/help_formatters/terminal_compact.rb:          ERB.new(File.read(File.join(File.dirname(__FILE__), 'terminal_compact', "#{name}.erb")), trim_mode: '-') ./vendor/bundle/ruby/3.1.0/gems/yard-0.9.27/benchmarks/erb_vs_erubis.rb:        def erb_with(str, x) ERB.new(str) end ./vendor/bundle/ruby/3.1.0/gems/yard-0.9.27/benchmarks/template_erb.rb:          erb = ERB.new(cache(section)) ./vendor/bundle/ruby/3.1.0/gems/yard-0.9.27/lib/yard/templates/template.rb:                ERB.new(content, :trim_mode => options.format == :text ? '<>' : nil) ./vendor/bundle/ruby/3.1.0/gems/yard-0.9.27/lib/yard/templates/template.rb:                ERB.new(content, nil, options.format == :text ? '<>' : nil) ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.3/lib/active_support/configuration_file.rb:        erb = ERB.new(@content).tap { |e| e.filename = @content_path } ./vendor/bundle/ruby/3.1.0/gems/domain_name-0.5.20190701/tool/gen_etld_data.rb:        rb.print ERB.new(erb.read).result(binding) ./vendor/bundle/ruby/3.1.0/gems/puppet-strings-2.9.0/lib/puppet-strings/markdown/base.rb:        ERB.new(File.read(file), nil, '-').result(binding) ./vendor/bundle/ruby/3.1.0/gems/puppet-strings-2.9.0/lib/puppet-strings/markdown/table_of_contents.rb:        final += ERB.new(File.read(template), nil, '-').result(binding) ./vendor/bundle/ruby/3.1.0/gems/serverspec-2.42.0/lib/serverspec/setup.rb:      content = ERB.new(spec_helper_template, nil, '-').result(binding) ./vendor/bundle/ruby/3.1.0/gems/beaker-4.35.0/lib/beaker/options/hosts_file_parser.rb:                     ERB.new(template, trim_mode: '-') ./vendor/bundle/ruby/3.1.0/gems/beaker-4.35.0/lib/beaker/options/hosts_file_parser.rb:                     ERB.new(template, nil, '-') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/config/default.yml:  Description: 'Use `:trim_mode` and `:eoutvar` keyword arguments to `ERB.new`.' ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/config_loader.rb:        yaml_code = Dir.chdir(File.dirname(absolute_path)) { ERB.new(file_contents).result } ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # ERB.new('hi', nil, '-', '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # ERB.new is deprecated. Do not use it, and specify other arguments as ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # ERB.new is deprecated. Use keyword argument like ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # ERB.new(str, trim_mode:...) instead. ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # example.rb:1: warning: Passing eoutvar with the 4th argument of ERB.new ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # is deprecated. Use keyword argument like ERB.new(str, eoutvar: ...) ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # `ERB.new` with non-keyword arguments is deprecated since ERB 2.2.0. ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # Use `:trim_mode` and `:eoutvar` keyword arguments to `ERB.new`. ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # This cop identifies places where `ERB.new(str, trim_mode, eoutvar)` can ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      # be replaced by `ERB.new(str, :trim_mode: trim_mode, eoutvar: eoutvar)`. ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #   ERB.new(str, nil, '-', '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #   ERB.new(str, trim_mode: '-', eoutvar: '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #   ERB.new(str, nil, '-', '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #   ERB.new(str, nil, '-', '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #     ERB.new(str, trim_mode: '-', eoutvar: '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #     ERB.new(str, nil, '-', '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #     ERB.new(str, trim_mode: '-', eoutvar: '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:      #     ERB.new(str, nil, '-', '@output_buffer') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:          'Passing safe_level with the 2nd argument of `ERB.new` is ' \ ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:          'Passing trim_mode with the 3rd argument of `ERB.new` is ' \ ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:          '`ERB.new(str, trim_mode: %<arg_value>s)` instead.', ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:          'Passing eoutvar with the 4th argument of `ERB.new` is ' \ ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/cop/lint/erb_new_arguments.rb:          '`ERB.new(str, eoutvar: %<arg_value>s)` instead.' ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/formatter/html_formatter.rb:                ERB.new(template, trim_mode: '-') ./vendor/bundle/ruby/3.1.0/gems/rubocop-1.22.3/lib/rubocop/formatter/html_formatter.rb:                ERB.new(template, nil, '-') ./vendor/bundle/ruby/3.1.0/gems/puppet-7.16.0/lib/puppet/face/help.rb:    erb = ERB.new(template.read, nil, '-') ./vendor/bundle/ruby/3.1.0/gems/puppet-7.16.0/lib/puppet/generate/type.rb:          template = ERB.new(File.read(key), nil, '-') ./vendor/bundle/ruby/3.1.0/gems/puppet-7.16.0/lib/puppet/parser/templatewrapper.rb:      template = ERB.new(string, 0, "-") ./vendor/bundle/ruby/3.1.0/gems/puppet-7.16.0/lib/puppet/util/resource_template.rb:    ERB.new(Puppet::FileSystem.read(@file, :encoding => 'utf-8'), 0, "-").result(binding) ./vendor/bundle/ruby/3.1.0/gems/puppet-syntax-3.2.1/lib/puppet-syntax/templates.rb:                ERB.new(template, trim_mode: '-') ./vendor/bundle/ruby/3.1.0/gems/puppet-syntax-3.2.1/lib/puppet-syntax/templates.rb:                ERB.new(template, nil, '-') ./vendor/bundle/ruby/3.1.0/gems/rspec-puppet-utils-3.4.0/lib/rspec_puppet_utils/template_harness.rb:      template = ERB.new(template_string, 0, '-') Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) If image attachments aren't displayed, see this article.

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11543 templatewrapper.rb depreciation warnings

Change By: Josh Cooper Epic Link: PUP-11544

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11543 templatewrapper.rb depreciation warnings

Change By: Josh Cooper Team: Phoenix

Add Comment