Jira (PUP-11540) Private tasks returned when listing tasks from the API

28 views
Skip to first unread message

Romain Tartière

unread,
May 11, 2022, 5:18:01 AM5/11/22
to puppe...@googlegroups.com
Romain Tartière created an issue
 
Puppet / Bug PUP-11540
Private tasks returned when listing tasks from the API
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2022/05/11 2:17 AM
Priority: Normal Normal
Reporter: Romain Tartière

Puppet Version: 7
Puppet Server Version: 7
OS Name/Version: any

When listing tasks using the API (GET /puppet/v3/tasks?environment=production), the returned list contain private tasks.

Desired Behavior:

Do not return tasks that are private, or maybe have a flag (off by default) to explicitly return such tasks.

This would be in-line with bolt which does not list private classes when running `bolt task show`.

Actual Behavior:

All tasks are always returned.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo

Romain Tartière

unread,
May 11, 2022, 5:20:01 AM5/11/22
to puppe...@googlegroups.com
Romain Tartière commented on Bug PUP-11540
 
Re: Private tasks returned when listing tasks from the API

The behavior looks inconsistent to me so I would appreciate some feedback from Puppet to know if this is something expected or some kind of bug that I can help fixing. Thanks!

Nirupama Mantha (Jira)

unread,
May 17, 2022, 4:32:02 PM5/17/22
to puppe...@googlegroups.com

Romuald Conty (Jira)

unread,
May 18, 2022, 6:27:02 AM5/18/22
to puppe...@googlegroups.com

IMHO, this function should return all tasks (i.e. including private) with a flag (eg. `private: true`) as we can run private tasks directly.

So, if we can run private tasks, we should provide a computer-way to known about these tasks.

Cas Donoghue (Jira)

unread,
May 24, 2022, 5:16:02 PM5/24/22
to puppe...@googlegroups.com
Cas Donoghue commented on Bug PUP-11540

I have an approval on the PR. I think its fine. 

Cas Donoghue (Jira)

unread,
May 24, 2022, 5:18:01 PM5/24/22
to puppe...@googlegroups.com
Cas Donoghue commented on Bug PUP-11540

We have not yet prioritized this. Will bring it up with margaret.harvison next PO sync. 

Cas Donoghue (Jira)

unread,
May 24, 2022, 5:18:01 PM5/24/22
to puppe...@googlegroups.com

Romain Tartière

unread,
May 31, 2022, 8:32:03 PM5/31/22
to puppe...@googlegroups.com
Romain Tartière updated an issue
Change By: Romain Tartière
*Puppet Version: 7*
*Puppet Server Version: 7*
*OS Name/Version: any*

When listing tasks using the API ({{{}GET /puppet/v3/tasks?environment=production{}}}), the returned list contain private tasks.

*Desired Behavior:*


Do not return tasks that are private, or maybe have a flag (off by default) to explicitly return such tasks.

This would be in-line with bolt which does not list private classes tasks when running `bolt task show`.

*Actual Behavior:*


All tasks are always returned.

Margaret Lee (Jira)

unread,
Jun 2, 2022, 4:54:03 PM6/2/22
to puppe...@googlegroups.com
Margaret Lee commented on Bug PUP-11540
 
Re: Private tasks returned when listing tasks from the API

smortex This is working as expected.

neomilium We are looking at if we can add something to show if the task is private or not. We need to look into what meta data to understand what we are grabbing today. Once we have this info we can look at prioritization for this

Cas Donoghue (Jira)

unread,
Jun 8, 2022, 1:29:01 PM6/8/22
to puppe...@googlegroups.com
Cas Donoghue updated an issue
 
Change By: Cas Donoghue
Sprint: Skeletor - 06/22/2022

Cas Donoghue (Jira)

unread,
Jun 21, 2022, 1:09:02 PM6/21/22
to puppe...@googlegroups.com

Cas Donoghue (Jira)

unread,
Jun 22, 2022, 1:15:01 PM6/22/22
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Sprint: Skeletor - 06/22/2022 , Skeletor - 07/06/2022

Cas Donoghue (Jira)

unread,
Jul 6, 2022, 1:05:03 PM7/6/22
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Release Notes: Enhancement
Release Notes Summary: Puppetserver now lists tasks in an environment with metadata including the task description and whether it is private or not.

Molly Waggett (Jira)

unread,
Jul 19, 2022, 2:42:04 PM7/19/22
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages