Jira (FACT-3115) virt-what-1.22-1 changes virtual=kvm to virtual=redhat

[Steve Traylen (Jira)]

Steve Traylen created an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat Issue Type: Bug Affects Versions: FACT 4.2.5 Assignee: Unassigned Components: Facter 4 Created: 2022/04/22 1:02 AM Priority: Normal Reporter: Steve Traylen The package virt-what-1.22-1.el9.x86_64 just landed in CentOS 9 . This upgrade changes virt-what's output from # virt-what kvm to # virt-what redhat kvm and now # facter virtual redhat The change in virt-what looks to be intentional: https://bugzilla.redhat.com/show_bug.cgi?id=2074476 http://git.annexia.org/?p=virt-what.git;a=commitdiff;h=b64df398779db07d008781c96685878795bcfd67 My feeling is that given kvm is still in the output the fact should still be reported as kvm for this case and the redhat label be ignored. (Just to add virt-what is no longer in the AIO package at all) Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Steve Traylen (Jira)]

Steve Traylen updated an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Steve Traylen Attachment: virtual.rb

Add Comment

[Steve Traylen (Jira)]

Steve Traylen commented on FACT-3115

Re: virt-what-1.22-1 changes virtual=kvm to virtual=redhat Adding virt-what backto puppet-agent would of course help here - https://tickets.puppetlabs.com/browse/PA-4423 which is probably why that ticket has jumped into some action. Anyone looking for quick stop gap, a custom fact to override this particular case virtual.rb

Add Comment

[Nacho Barrientos (Jira)]

Nacho Barrientos commented on FACT-3115

Re: virt-what-1.22-1 changes virtual=kvm to virtual=redhat

This is also affecting CentOS Stream 8 now. I've contributed a patch: https://github.com/puppetlabs/facter/pull/2485

Add Comment

[Nirupama Mantha (Jira)]

Nirupama Mantha updated an issue

Facter / FACT-3115

virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Nirupama Mantha Story Points: 1

Add Comment

[Nirupama Mantha (Jira)]

Nirupama Mantha updated an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Nirupama Mantha Sprint: Phoenix 2022-05-11

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Michael Hashizume Sprint: Phoenix 2022-05-11

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Michael Hashizume Sprint: Phoenix 2022-05-11

Team: Phoenix

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume assigned an issue to Michael Hashizume

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Michael Hashizume Assignee: Michael Hashizume

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Michael Hashizume Fix Version/s: FACT 4.2.10

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume commented on FACT-3115

Re: virt-what-1.22-1 changes virtual=kvm to virtual=redhat Merged and passing CI in 034fbc0e50e10287b1ed3a1e1d5f1ed5f63d65a4. Thank you again for your contribution nbarrientos !

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3115

virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Fix contributed by GitHub user nbarrientos

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Facter / FACT-3115 virt-what-1.22-1 changes virtual=kvm to virtual=redhat

Change By: Parker Leach Labels: docs_reviewed

Add Comment