Jira (PUP-11456) Puppet::Confiner Ruby 3 rspec failure

16 views
Skip to first unread message

Michael Hashizume (Jira)

unread,
Feb 15, 2022, 12:35:02 PM2/15/22
to puppe...@googlegroups.com
Michael Hashizume created an issue
 
Puppet / Task PUP-11456
Puppet::Confiner Ruby 3 rspec failure
Issue Type: Task Task
Assignee: Unassigned
Created: 2022/02/15 9:34 AM
Priority: Normal Normal
Reporter: Michael Hashizume

We've started to see rspec failures on one unit test for Puppet::Confiner with Ruby 3. You can see an example of this in this GitHub Action running Ruby 3.0.3 and rspec 3.11.0 on Ubuntu 18.04: https://github.com/puppetlabs/puppet/runs/5192746837?check_suite_focus=true#step:6:202

1) Puppet::Confiner should delegate its confine method to its confine collection
     Failure/Error: confine_collection.confine(hash)
       #<Double "collection"> received :confine with unexpected arguments
         expected: ({:bee=>:baz, :foo=>:bar})
              got: ({:bee=>:baz, :foo=>:bar})
     # ./lib/puppet/confiner.rb:27:in `confine'
     # ./spec/unit/confiner_spec.rb:27:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:180:in `block (2 levels) in <top (required)>'
     # util/rspec_runner:44:in `run'
     # util/rspec_runner:59:in `<main>'
Finished in 13.16 seconds (files took 1.78 seconds to load)
 
Finished in 2 minutes 6 seconds
25193 examples, 1 failure, 22 pending
 
Failed examples:
rspec ./spec/unit/confiner_spec.rb:23 # Puppet::Confiner should delegate its confine method to its confine collection

The expected and actual output look identical and running the test on its own, locally, it shows an empty diff between expected and actual.

We need to investigate what changes in Ruby 3 are causing this behavior.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo

Michael Hashizume (Jira)

unread,
Feb 15, 2022, 12:58:02 PM2/15/22
to puppe...@googlegroups.com

Nirupama Mantha (Jira)

unread,
Feb 15, 2022, 4:13:02 PM2/15/22
to puppe...@googlegroups.com

Nirupama Mantha (Jira)

unread,
Feb 15, 2022, 4:14:01 PM2/15/22
to puppe...@googlegroups.com
Nirupama Mantha updated an issue
Change By: Nirupama Mantha
Labels: ruby3.0.3

Josh Cooper (Jira)

unread,
Feb 16, 2022, 1:02:02 AM2/16/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2022-03-02

Josh Cooper (Jira)

unread,
Feb 16, 2022, 8:40:02 PM2/16/22
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper
Change By: Josh Cooper
Assignee: Josh Cooper

Josh Cooper (Jira)

unread,
Feb 16, 2022, 8:40:03 PM2/16/22
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Feb 22, 2022, 6:39:02 PM2/22/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.15.0

Josh Cooper (Jira)

unread,
Feb 22, 2022, 6:39:02 PM2/22/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Not Needed
Reply all
Reply to author
Forward
0 new messages