Jira (PUP-11405) Replace deprecated/changed Psych YAML methods, pin rdoc

18 views
Skip to first unread message

Raul Tambre (Jira)

unread,
Jan 5, 2022, 4:05:06 AM1/5/22
to puppe...@googlegroups.com
Raul Tambre updated an issue
 
Puppet / Task PUP-11405
Replace deprecated/changed Psych YAML methods, pin rdoc
Change By: Raul Tambre
Summary: Replace deprecated /changed Psych YAML load method methods, pin rdoc
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo

Raul Tambre (Jira)

unread,
Jan 5, 2022, 4:07:01 AM1/5/22
to puppe...@googlegroups.com
Raul Tambre updated an issue
Puppet uses the non-keyword variant of Psych's {{ YAML.safe_load }} , which was deprecated in 3.1.0 with the replacement also introduced in that version. Psych 4.0.0 has removed the deprecated variant and thus we should switch to the new variant albeit with a version check since we still support older Ruby versions, which ship pre-3.1.0 Psych versions.

 Furthermore, {{YAML.load_file}} has been changed to a safe variant in 4.0.1 breaking some tests. Puppet's wrapper for it should be updated to use {{YAML.unsafe_load_file}} when available (since 3.3.2) to keep the same behaviour.

 As a minor side issue rdoc has switched to Psych 4.0.0 in a minor version causing CI breakage due to rubocop not having been updated for the deprecation yet.

Josh Cooper (Jira)

unread,
Jan 5, 2022, 1:01:01 PM1/5/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Phoenix

Josh Cooper (Jira)

unread,
Jan 5, 2022, 1:01:02 PM1/5/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.14.0
Fix Version/s: PUP 6.26.0

Josh Cooper (Jira)

unread,
Jan 5, 2022, 3:36:01 PM1/5/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2022-01-18

Josh Cooper (Jira)

unread,
Jan 7, 2022, 3:18:03 PM1/7/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Bug Fix
Release Notes Summary: Puppet is now compatible with psych 4.0

Josh Cooper (Jira)

unread,
Jan 7, 2022, 3:19:02 PM1/7/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Community Contributors: tambry

Parker Leach (Jira)

unread,
Jan 11, 2022, 2:10:02 PM1/11/22
to puppe...@googlegroups.com
Parker Leach updated an issue
Change By: Parker Leach
Labels: docs_reviewed

Josh Cooper (Jira)

unread,
Feb 23, 2022, 12:02:01 AM2/23/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: 7.15.0
Reply all
Reply to author
Forward
0 new messages