Jira (FACT-3089) Processor ISA fact on Linux reports wrong data if the string contains a period

[Alexander Olofsson (Jira)]

Alexander Olofsson created an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period Issue Type: Bug Affects Versions: FACT 4.2.4, FACT 4.0.43 Assignee: Unassigned Components: Facter 4 Created: 2021/10/29 12:32 AM Priority: Normal Reporter: Alexander Olofsson   As an example from a machine running Puppet 6; # facter --version 3.14.14 (commit e36657bea27254f003c8fc71d8ef57454db643e2) # facter processors.isa Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz # facter-ng --version    4.0.43 # facter-ng processors.isa 20GHz And from one running Puppet 7; $ facter --version 4.2.4 $ facter processors.isa 80GHz $ uname -p Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz   Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Ciprian Badescu (Jira)]

Ciprian Badescu commented on FACT-3089

Re: Processor ISA fact on Linux reports wrong data if the string contains a period Alexander Olofsson, the output of `uname -p` is unusual, on which OS/version do you have this issue?

Add Comment

[Alexander Olofsson (Jira)]

Alexander Olofsson commented on FACT-3089

Re: Processor ISA fact on Linux reports wrong data if the string contains a period

The examples there were from a pair of machines running Gentoo. Could be related to the version of coreutils (8.32).

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-3089

Re: Processor ISA fact on Linux reports wrong data if the string contains a period

Facter 3 calls uname -p in the default posix processor resolver: https://github.com/puppetlabs/facter/blob/abb9990f1989d99eab8e4602e85dd0f7b9819db4/lib/src/facts/posix/processor_resolver.cc#L15 and returns that value verbatim. Facter 4 calls uname -p but it splits the output on dots: https://github.com/puppetlabs/facter/blob/88a4f07aca392d438792c329994c462de0c7746b/lib/facter/facts/linux/processors/isa.rb#L20 It was originally implemented that way in https://github.com/puppetlabs/facter/commit/6ba4bd1b2b6f5e871d975d98ae0472cf41580c32#diff-41c8b651faa41036e4010c0e5ae74f54fb405f4049f46340a8882c495b2d41b5R18, but I don't think that makes sense. We should just return whatever uname -p returns. Side note: uname -p is not portable, see https://github.com/coreutils/coreutils/commit/6d67649d86a0dcfefb4dfbc0c29f8bb7595f14bb

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3089

Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Josh Cooper Team: Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Josh Cooper Sprint: Phoenix 2022-05-11

Add Comment

[Nirupama Mantha (Jira)]

Nirupama Mantha updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Nirupama Mantha Sprint: Phoenix 2022-05- 11 25

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Michael Hashizume Story Points: 2

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Michael Hashizume Acceptance Criteria: {color:#000000}facter processors.isa properly returns processor information. {color}

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Michael Hashizume Fix Version/s: FACT 4.2.10

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-3089

Re: Processor ISA fact on Linux reports wrong data if the string contains a period One note, the desired/actual behavior depends on the OS (since uname -p isn't portable). For example, on Ubuntu 20.04, I get: $ dpkg -l coreutils Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-==============-=============-============-================================= ii coreutils 8.30-3ubuntu2 amd64 GNU core utilities $ uname -p x86_64 $ bundle exec facter processors.isa x86_64 So to fix this issue, you'll want to test it on an OS where "uname -p" returns something like "Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz"

Add Comment

[Tony Vu (Jira)]

Tony Vu updated an issue

Facter / FACT-3089

Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Tony Vu Sprint: Phoenix 2022- 05 06 - 25 08

Add Comment

[Lisa Ross (Jira)]

Lisa Ross updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Lisa Ross Sprint: Phoenix 2022-06-08

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Aria Li Fix Version/s: FACT 4.2.10

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Josh Cooper Labels: regression

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Josh Cooper Epic Link: PUP-11658

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Josh Cooper Priority: Normal High

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Josh Cooper Sprint: Phoenix 2023-06-07

Add Comment

This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)

[Michael Hashizume (Jira)]

Michael Hashizume assigned an issue to Michael Hashizume

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Michael Hashizume Assignee: Michael Hashizume

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Facter / FACT-3089 Processor ISA fact on Linux reports wrong data if the string contains a period

Change By: Michael Hashizume Release Notes: Bug Fix Release Notes Summary: Facter no longer modifies `uname -p` output when reporting the processors.isa fact on Linux platforms.

Add Comment