Jira (PUP-11314) Requiring files inside settings hook is slow on Windows

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-11314 Requiring files inside settings hook is slow on Windows Issue Type: Bug Assignee: Unassigned Created: 2021/10/05 9:23 AM Priority: Normal Reporter: Josh Cooper Calling require/require_relative inside of the storeconfigs setting hook is really slow on Windows: https://github.com/puppetlabs/puppet/blob/75737603872883d8d72224e2a6857804938f9634/lib/puppet/defaults.rb#L2122-L2123 It appears to add several minutes to the overall rspec time on Windows. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11314

Re: Requiring files inside settings hook is slow on Windows The issue is on_initialize_and_write hooks are called at the start of every test, so we're calling require/require_relative about ~40k times. Also the factpath setting has a similar hook and we keep appending the same 2 directories to the facter search path.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-11314

Requiring files inside settings hook is slow on Windows

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11314 Requiring files inside settings hook is slow on Windows

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11314 Requiring files inside settings hook is slow on Windows

Change By: Josh Cooper Sprint: Coremunity Kanban

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11314 Requiring files inside settings hook is slow on Windows

Change By: Josh Cooper Fix Version/s: PUP 6.26.0 Fix Version/s: PUP 7.13.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11314 Requiring files inside settings hook is slow on Windows

Change By: Josh Cooper Release Notes: Not Needed

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy commented on PUP-11314

Re: Requiring files inside settings hook is slow on Windows Merged to 6.x in https://github.com/puppetlabs/puppet/commit/b5e3d4e5a206010119f4c67b36c94983cae32d65

Add Comment