Jira (PUP-11204) puppet lookup --facts {filename} fails if filename does not contain a dot

Reinhard Vicinus (Jira)

unread,

Aug 9, 2021, 10:42:02 AM8/9/21

to puppe...@googlegroups.com

Reinhard Vicinus created an issue

Puppet /

PUP-11204

puppet lookup --facts {filename} fails if filename does not contain a dot

Issue Type:	Bug
Affects Versions:	PUP 6.23.0
Assignee:	Unassigned
Created:	2021/08/09 7:41 AM
Priority:	Normal
Reporter:	Reinhard Vicinus

Calling:

puppet lookup --facts dummy keyX

Error: Could not parse application options: undefined method `[]' for nil:NilClass

Fails because the code that verifies the filename expects, that the filename contains a dot:

  option('--facts FACT_FILE') do |arg|

    if %w{.yaml .yml .json}.include?(arg.match(/\.[^.]*$/)[0])

      options[:fact_file] = arg

    else

      raise _("The --fact file only accepts yaml and json files.\n%{run_help}") % { run_help: RUN_HELP }

end

end

Also, verifying based on the filename that the file contains json/yaml data is not correct in my opinion. In my opinion, the following should also be supported:

puppet lookup --facts <(puppet facts find $nodename | jq .values) --node $nodename keyX

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

Gheorghe Popescu (Jira)

unread,

Aug 16, 2021, 10:23:02 AM8/16/21

to puppe...@googlegroups.com

Gheorghe Popescu updated an issue

Puppet /

PUP-11204

puppet lookup --facts {filename} fails if filename does not contain a dot

Change By:	Gheorghe Popescu
Epic Link:	PUP-11052

Add Comment

Ciprian Badescu (Jira)

unread,

Oct 6, 2021, 4:50:03 AM10/6/21

to puppe...@googlegroups.com

Ciprian Badescu updated an issue

Puppet /

PUP-11204

puppet lookup --facts {filename} fails if filename does not contain a dot

Change By:	Ciprian Badescu
Story Points:	2

Add Comment

Luchian Nemes (Jira)

unread,

Oct 6, 2021, 5:08:03 AM10/6/21

to puppe...@googlegroups.com

Luchian Nemes assigned an issue to Luchian Nemes

Puppet /

PUP-11204

puppet lookup --facts {filename} fails if filename does not contain a dot

Change By:	Luchian Nemes
Assignee:	Luchian Nemes

Add Comment

Ciprian Badescu (Jira)

unread,

Oct 20, 2021, 4:20:02 AM10/20/21

to puppe...@googlegroups.com

Ciprian Badescu updated an issue

Puppet /

PUP-11204

puppet lookup --facts {filename} fails if filename does not contain a dot

Change By:	Ciprian Badescu
Sprint:	NW - 2021-10-20 , NW - 2021-11-03

Add Comment

Luchian Nemes (Jira)

unread,

Nov 1, 2021, 9:21:02 AM11/1/21

to puppe...@googlegroups.com

Luchian Nemes updated an issue

Puppet /

PUP-11204

puppet lookup --facts {filename} fails if filename does not contain a dot

Change By:	Luchian Nemes
Release Notes:	Bug Fix
Release Notes Summary:	Before this release, `puppet lookup --facts {filename}` failed early when the filename given did not contain a dot. This fix removes the early extensions check and adds a fallback instead — tries both formats (JSON then YAML) to read the given facts file when its path doesn't end with any of the expected extensions (yaml/yml/json). Otherwise, it follows previous implementation and respects given extension.