Jira (FACT-3064) Please update Google GCE instance check

[Sven Mueller (Jira)]

Sven Mueller created an issue

Facter / FACT-3064 Please update Google GCE instance check Issue Type: Bug Assignee: Unassigned Components: Facter 3, Facter 4 Created: 2021/08/09 1:40 AM Priority: Normal Reporter: Sven Mueller Hi.   Currently, Facter checks if it is running on Google's GCE by checking if the bios vendor is "Google". However, this happens to also be the case on some non-GCE systems (I think also in the Linux VM on Chromebooks as well as some other odd systems), leading to timeout when trying to talk to the Metadata server. https://cloud.google.com/compute/docs/instances/managing-instances has updated the detection method (avoiding the metadata server) to: sudo dmidecode -s system-product-name | grep "Google Compute Engine" Google Compute Engine For Linux. Please update facter accordingly. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Gheorghe Popescu (Jira)]

Gheorghe Popescu updated an issue

Facter / FACT-3064 Please update Google GCE instance check

Change By: Gheorghe Popescu Labels: help_wanted

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu commented on FACT-3064

Re: Please update Google GCE instance check Thank you for filing this issue. We agree it is likely an improvement, but due to other issues demanding precedence, we don’t anticipate being able to address this any time soon. If you are interested in submitting a patch to the repository for this project at https://github.com/puppetlabs/facter, please open a pull request.

Add Comment

[Kyle Knobloch (Jira)]

Kyle Knobloch commented on FACT-3064

Re: Please update Google GCE instance check

Hello, I've recently run into a similar situation. I have LXD containers running on a Google machine and it believes the host is virtual as well as the LXD containers being identified as 'gce' instead of 'lxd'.     It seems the check_gce fact is extremely broad resulting in these issues.  https://github.com/puppetlabs/facter/blob/a2c141ac927c6e8d13b88ed4c54e3899aea8f306/lib/facter/util/facts/posix/virtual_detector.rb#L23-L26

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)