Jira (FACT-3060) AIX producing "Could not resolve mountpoints" with Facter 4

18 views
Skip to first unread message

Austin Boyd (Jira)

unread,
Jul 28, 2021, 11:14:02 AM7/28/21
to puppe...@googlegroups.com
Jordi Garcia created an issue
 
Facter / Bug FACT-3060
AIX producing "Could not resolve mountpoints" with Facter 4
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2021/07/28 8:13 AM
Priority: Normal Normal
Reporter: Jordi Garcia

After agent upgrade to puppet-agent-7.8.0-1.aix7.1.ppc.rpm with facter 4.2, facter is producing "Could not resolve mountpoints" errors. This was not the case when using facter 3.14

* Please see Zendesk Support tab for further comments and attachments.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Austin Boyd (Jira)

unread,
Jul 28, 2021, 11:14:03 AM7/28/21
to puppe...@googlegroups.com
Austin Boyd updated an issue
Change By: Austin Boyd
Zendesk Ticket Count: 1
Zendesk Ticket IDs: 45161

Austin Boyd (Jira)

unread,
Jul 28, 2021, 11:14:04 AM7/28/21
to puppe...@googlegroups.com

Gheorghe Popescu (Jira)

unread,
Jul 29, 2021, 3:01:04 AM7/29/21
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
After agent upgrade to puppet-agent-7.8.0-1.aix7.1.ppc.rpm with facter 4.2, facter is producing "Could not resolve mountpoints" errors. This was not the case when using facter 3.14

facter 4 removes anything that contains the word node: https://github.com/puppetlabs/facter/blame/main/lib/facter/resolvers/aix/mountpoints.rb#L22

but this is causing failures when we combine mount data with df data(from where node is not removed): https://github.com/puppetlabs/facter/blame/main/lib/facter/resolvers/aix/mountpoints.rb#L37

in cfacter we do not skip node: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/aix/filesystem_resolver.cc#L55-L62

How to reproduce the issue:
Add the following data to facter fixtures :

{noformat}
# spec/fixtures/mount

  node       mounted        mounted over    vfs       date        options
-------- ---------------  ---------------  ------ ------------ ---------------
         /dev/hd1         /                x   July 26 19:04 rw,log=/dev/hd3
         /dev/hd2         /usr          x   July 26 19:04 rw,nodev,log=/dev/hd3


# spec/fixtures/df

Filesystem    512-blocks      Used Available Capacity Mounted on
/dev/hd1         1    1    1      1% /
/dev/hd2         1    1    1      1% /usr


{noformat}

debug the tests: bundle exec rspec spec/facter/resolvers/aix/mountpoints_spec.rb




~* Please see Zendesk Support tab for further comments and attachments.~

Gheorghe Popescu (Jira)

unread,
Jul 29, 2021, 3:06:04 AM7/29/21
to puppe...@googlegroups.com

Gheorghe Popescu (Jira)

unread,
Jul 29, 2021, 3:06:04 AM7/29/21
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Jul 30, 2021, 8:28:03 AM7/30/21
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Aug 3, 2021, 4:55:04 AM8/3/21
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Aug 11, 2021, 5:05:02 AM8/11/21
to puppe...@googlegroups.com

Victor Bobosila (Jira)

unread,
Aug 11, 2021, 9:11:02 AM8/11/21
to puppe...@googlegroups.com

Victor Bobosila (Jira)

unread,
Aug 16, 2021, 6:50:03 AM8/16/21
to puppe...@googlegroups.com
Victor Bobosila updated an issue
Change By: Victor Bobosila
Release Notes: Bug Fix
Release Notes Summary: Fixed faulty regex on AIX that would skip any lines that would have the substring `node` in them, resulting in the `Could not resolve mountpoints` error.(e.g If there would be a `nodev` option, the respective mountpoint would be skipped)

Ciprian Badescu (Jira)

unread,
Sep 8, 2021, 10:15:02 AM9/8/21
to puppe...@googlegroups.com

Claire Cadman (Jira)

unread,
Sep 9, 2021, 7:28:02 AM9/9/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc-reviewed jira_escalated
Reply all
Reply to author
Forward
0 new messages