Jira (FACT-3058) Add DisplayVersion fact for Windows machines

22 views
Skip to first unread message

Gabriel Nagy (Jira)

unread,
Jul 28, 2021, 7:06:05 AM7/28/21
to puppe...@googlegroups.com
Gabriel Nagy created an issue
 
Facter / New Feature FACT-3058
Add DisplayVersion fact for Windows machines
Issue Type: New Feature New Feature
Assignee: Unassigned
Created: 2021/07/28 4:05 AM
Labels: community
Priority: Normal Normal
Reporter: Gabriel Nagy

Context from https://www.lansweeper.com/forum/yaf_postsm65291_Windows-10-Version-Number-Wrong.aspx#post65291

Microsoft has changed the identifier in the registry for the version number.

"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\ReleaseID" is the old location for the version number, 1803, 1909 and such.

"HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\DisplayVersion" is now the new location as of 2009 (20H2) but does not exist prior to 2009.

The issue I have seen is that they stopped at 2009 and did not remove the old entry when they decided to create the new one. This means there is an old entry of 2009 still in the registry.


Also discussed on the Community Slack: https://puppetcommunity.slack.com/archives/C0W298S9G/p1627455331127400

Facter currently provides both the build number and release ID as core facts (os.windows.release_id and kernelversion).

What we need to do:

  • add a new os.windows.display_version fact that reads the version from the DisplayVersion registry key
  • based on the build version, make the existing release_id fact point to display_version and the other way around (this is to keep backwards compatibility and avoid breaking existing installations)
    • on versions older than 20H2: display_version should resolve to release_id
    • on 20H2 (last version to increment the Release ID): the facts should show different versions
    • on versions newer than 20H2: release_id should resolve to display_version
  Version 2004 (May 2020 Update) Version 20H2 (October 2020 Update) Version 21H1 (May 2021 Update)
DisplayVersion n/a 20H2 21H1
Release ID 2004 2009 2009 (presumably deprecated and not to be further updated by Microsoft)
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Aug 2, 2021, 10:28:02 AM8/2/21
to puppe...@googlegroups.com
Ciprian Badescu commented on New Feature FACT-3058
 
Re: Add DisplayVersion fact for Windows machines

Gabriel Nagy does it only affects Windows 10 or also Windows Server line?

Ciprian Badescu (Jira)

unread,
Aug 2, 2021, 10:29:02 AM8/2/21
to puppe...@googlegroups.com

Gabriel Nagy (Jira)

unread,
Aug 2, 2021, 10:41:03 AM8/2/21
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Sep 28, 2021, 3:47:02 AM9/28/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
 
Change By: Ciprian Badescu
Sprint: NW - 2021-10-06

Ciprian Badescu (Jira)

unread,
Sep 28, 2021, 3:48:01 AM9/28/21
to puppe...@googlegroups.com
Ciprian Badescu assigned an issue to Unassigned
Change By: Ciprian Badescu
Assignee: Ciprian Badescu

Gabriel Nagy (Jira)

unread,
Sep 28, 2021, 6:07:03 AM9/28/21
to puppe...@googlegroups.com
Gabriel Nagy assigned an issue to Luchian Nemes
Change By: Gabriel Nagy
Assignee: Luchian Nemes

Gabriel Nagy (Jira)

unread,
Sep 28, 2021, 6:10:01 AM9/28/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Fix Version/s: FACT 4.2.5

Gabriel Nagy (Jira)

unread,
Sep 29, 2021, 5:56:02 AM9/29/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Fix Version/s: FACT 3.14.20

Luchian Nemes (Jira)

unread,
Sep 30, 2021, 4:46:03 AM9/30/21
to puppe...@googlegroups.com

Luchian Nemes (Jira)

unread,
Oct 1, 2021, 4:18:01 AM10/1/21
to puppe...@googlegroups.com
Luchian Nemes updated an issue
Change By: Luchian Nemes
Release Notes: Bug Fix
Release Notes Summary: The original source of information for the `os.windows.release_id` fact hasn't been updated for a while and this release fixes it by querying the right (new) registry key when it's available. This also adds a new fact called `os.windows.display_version` which in the next major release of Facter will replace `os.windows.release_id`.

Claire Cadman (Jira)

unread,
Oct 5, 2021, 8:21:02 AM10/5/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: community doc-reviewed

Claudia Petty (Jira)

unread,
Jun 21, 2023, 8:43:02 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: community doc-reviewed new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages