Jira (PUP-11164) launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

[Clay Caviness (Jira)]

Clay Caviness created an issue

Puppet / PUP-11164 launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists Issue Type: Bug Affects Versions: PUP 7.8.0 Assignee: Unassigned Components: Types and Providers Created: 2021/07/08 3:49 PM Priority: Normal Reporter: Clay Caviness If a file in the LaunchAgents or LaunchDaemons paths is encountered that's parseable by Puppet::Util::Plist.read_plist_from_file but not a valid launchd plist file, then Puppet will crash with an error. To reproduce: # echo "aaa" >/Library/LaunchDaemons/invalid.txt # puppet resource service Error: Could not run: undefined method `has_key?' for "aaa":String In launchd.rb line 141, the parsed plist (job) is checked with .has_key? to ensure a Label is present. If the parsed plist is not a Hash, though, this will fail. I expect the correct course of action is to add a job.is_a?(Hash) check first. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Clay Caviness (Jira)]

Clay Caviness commented on PUP-11164

Re: launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists I think https://github.com/puppetlabs/puppet/pull/8683 fixes this.

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11164

launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

Change By: Ciprian Badescu Sprint: NW-2021-07-28

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11164 launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

Change By: Ciprian Badescu Team: Night's Watch

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-11164 launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

Change By: Ciprian Badescu Story Points: 1

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11164

Re: launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists Merged to 6.x in https://github.com/puppetlabs/puppet/commit/9ba5f98d4a1c50d6bed6e6e7cc4c2204b1b370b0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11164

launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

Change By: Josh Cooper Fix Version/s: PUP 7.10.0 Fix Version/s: PUP 6.25.0

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-11164 launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

Change By: Gabriel Nagy Community Contributors: ccaviness

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-11164 launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

Change By: Claire Cadman Labels: doc-reviewed

Add Comment