Jira (PUP-11077) Passing SemVer prerelease or build as a hash doesn't work

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work Issue Type: Bug Assignee: Unassigned Created: 2021/06/01 3:39 PM Priority: Normal Reporter: Josh Cooper The language specification says you should be able to pass the SemVer prerelease and build components as a hash. However, the values are corrupted when SemVer objects are created this way: ❯ bx puppet apply -e 'notice(SemVer(major => 1, minor => 0, patch => 0, prerelease => "alpha"))' Notice: Scope(Class[main]): 1.0.0-a.l.p.h.a ... ❯ bx puppet apply -e 'notice(SemVer(major => 1, minor => 0, patch => 0, build => "123"))' Notice: Scope(Class[main]): 1.0.0+1.2.3 ... Note the extra dots in the output. The problem is that the SemVer data type needs to pass the build and prerelease components as a single element array when calling SemanticPuppet::Version.new(.., prerelease, build) Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Josh Cooper The [language specification|https://github.com/puppetlabs/puppet-specifications/blob/master/language/types_values_variables.md#semvernew] says you should be able to pass the SemVer {{prerelease}} and {{build}} components as a hash. However, the values are corrupted when SemVer objects are created this way: {noformat}

❯ bx puppet apply  -e 'notice(SemVer(major => 1, minor => 0, patch => 0, prerelease => "alpha"))' Notice: Scope(Class[main]): 1.0.0-a.l.p.h.a ... ❯ bx puppet apply  -e 'notice(SemVer(major => 1, minor => 0, patch => 0, build => "123"))'        Notice: Scope(Class[main]): 1.0.0+1.2.3 ...

{noformat} Note the extra dots in the output. This leads to confusing behavior: {noformat} ❯ bx puppet apply  -e 'notice(SemVer(major => 1, minor => 0, patch => 0, build => "123") == SemVer("1.0.0+123"))' Notice: Scope(Class[main]): false {noformat} Passing the build and prerelease components in the string version does work, because internally {{SemanticPuppet::Version.parse}} converts the [String component to an array|https://github.com/puppetlabs/semantic_puppet/blob/3ef28a432846c0d5492be1af3a412a1695b4b4b6/lib/semantic_puppet/version.rb#L38].

The problem is that the SemVer data type needs to pass the build and prerelease components as a single element array when calling {{SemanticPuppet::Version.new(.., prerelease, build)}}

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Josh Cooper Fix Version/s: PUP 7.8.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work Change By: Josh Cooper

The [language specification|https://github.com/puppetlabs/puppet-specifications/blob/master/language/types_values_variables.md#semvernew] says you should be able to pass the SemVer {{prerelease}} and {{build}} components as a hash or list of arguments . However, the values are corrupted when SemVer objects are created this way:

{noformat} ❯ bx puppet apply  -e 'notice(SemVer(major => 1, minor => 0, patch => 0, prerelease => "alpha"))' Notice: Scope(Class[main]): 1.0.0-a.l.p.h.a ... ❯ bx puppet apply  -e 'notice(SemVer(major => 1, minor => 0, patch => 0, build => "123"))'        Notice: Scope(Class[main]): 1.0.0+1.2.3 ... {noformat} Note the extra dots in the output. This leads to confusing behavior: {noformat} ❯ bx puppet apply  -e 'notice(SemVer(major => 1, minor => 0, patch => 0, build => "123") == SemVer("1.0.0+123"))' Notice: Scope(Class[main]): false {noformat} Passing the build and prerelease components in the string version does work, because internally {{SemanticPuppet::Version.parse}} converts the [String component to an array|https://github.com/puppetlabs/semantic_puppet/blob/3ef28a432846c0d5492be1af3a412a1695b4b4b6/lib/semantic_puppet/version.rb#L38]. The problem is that the SemVer data type needs to pass the build and prerelease components as a single element array when calling {{SemanticPuppet::Version.new(.., prerelease, build)}}

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy commented on PUP-11077

Re: Passing SemVer prerelease or build as a hash doesn't work Merged to 6.x in https://github.com/puppetlabs/puppet/commit/8daf4341c0b55c152792121633c59ee76ee9d722

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-11077

Passing SemVer prerelease or build as a hash doesn't work

Change By: Gabriel Nagy Fix Version/s: PUP 6.23.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Fixes a bug that prevented the build and prerelease components of the SemVer data type from being passed as a list of arguments or hash: SemVer(major => 1, minor => 0, patch => 0, prerelease => "beta", build => "123") SemVer(1, 0, 0, "beta", "123")

Add Comment

[Christine Yoon (Jira)]

Christine Yoon updated an issue

Puppet / PUP-11077 Passing SemVer prerelease or build as a hash doesn't work

Change By: Christine Yoon Labels: docs-reviewed

Add Comment