Jira (PDB-5131) Enable drop joins by default

[Austin Blatt (Jira)]

Austin Blatt created an issue

PuppetDB / PDB-5131 Enable drop joins by default Issue Type: Improvement Assignee: Unassigned Created: 2021/05/18 3:41 PM Priority: Normal Reporter: Austin Blatt Drop joins has shown that it can significantly speed up nodes queries, so we should enable it by default for that entity. We should test that drop joins can be disabled, so that users can back out of this change if they encounter errors. Initially this will target main so that 6.x will be more stable. If it proves stable, we may backport it later. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Austin Blatt Epic Link: PE-31891

Add Comment

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Zachary Kent Story Points: 1

Add Comment

[Zachary Kent (Jira)]

Zachary Kent commented on PDB-5131

Re: Enable drop joins by default only do this in 7 to start

Add Comment

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-5131

Enable drop joins by default

Change By: Zachary Kent Sprint: HAHA/Grooming HA 2021-06-02

Add Comment

[Zachary Kent (Jira)]

Zachary Kent assigned an issue to Zachary Kent

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Zachary Kent Assignee: Zachary Kent

Add Comment

[Eric Thompson (Jira)]

Eric Thompson updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Eric Thompson Sprint: HA 2021-06-02 , HA 2021-06-16

Add Comment

[Eric Thompson (Jira)]

Eric Thompson updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Eric Thompson Sprint: HA 2021-06-02 HAHA/Grooming , HA 2021-06- 16 02

Add Comment

[Carl Caum (Jira)]

Carl Caum commented on PDB-5131

Re: Enable drop joins by default Aidan Nathanson FYI on this work. It will significantly increase the performance of many PuppetDB queries, but it does introduce minimal potential risk of breaking some existing queries. The rollout plan is the following: 1) Turn it on by default in open source PuppetDB 7 2) Once it's baked in 7 for a while, it will be turned on by default in open source PuppetDB 6 3) Turn it on by default for the next PE release If customers run into issues as a result of this change, it can be turned off per customer following these instructions: https://puppet.com/docs/puppetdb/latest/api/query/v4/query.html#experimental-query-optimization Prior to rolling it out in PE, CS will need to be made aware of this change and Support specifically will need to know how to turn it off if they receive support issues about it.

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5131

Enable drop joins by default

Change By: Austin Blatt Sprint: HAHA/Grooming, HA 2021-06-02 , HA 2021-07-14

Add Comment

[Austin Blatt (Jira)]

Austin Blatt assigned an issue to Unassigned

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Austin Blatt Assignee: Zachary Kent

Add Comment

[Rob Browning (Jira)]

Rob Browning assigned an issue to Rob Browning

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Rob Browning Assignee: Rob Browning

Add Comment

[Eric Thompson (Jira)]

Eric Thompson updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Eric Thompson Labels: 2021-o1-kr2

Add Comment

[Carl Caum (Jira)]

Carl Caum commented on PDB-5131

Re: Enable drop joins by default Zachary Kent Do we have any idea of what query failures from this will look like? I want to make sure we have a knowledge base article to identify issues that might arise from this and point to the docs to turn it off.

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5131

Enable drop joins by default

Change By: Austin Blatt Fix Version/s: PDB 7.5.0

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Austin Blatt Release Notes: Enhancement

Add Comment

[Rob Browning (Jira)]

Rob Browning updated an issue

PuppetDB / PDB-5131 Enable drop joins by default

Change By: Rob Browning Release Notes: Enhancement Release Notes Summary: The query optimizer https://puppet.com/docs/puppetdb/latest/api/query/v4/query.html#experimental-query-optimization that attempts to drop unneeded joins is now enabled by default, but that can be changed by setting the PDB_QUERY_OPTIMIZE_DROP_UNUSED_JOINS environment variable.

Add Comment