Jira (FACT-3031) Add os.macosx.version.patch fact

17 views
Skip to first unread message

Clay Caviness (Jira)

unread,
Apr 22, 2021, 11:47:02 AM4/22/21
to puppe...@googlegroups.com
Clay Caviness created an issue
 
Facter / New Feature FACT-3031
Add os.macosx.version.patch fact
Issue Type: New Feature New Feature
Assignee: Unassigned
Components: Facter 4
Created: 2021/04/22 8:46 AM
Priority: Normal Normal
Reporter: Clay Caviness

Starting with macOS 11, Apple has more clearly started using major.minor.patch for OS versions.

FACT-2914 changes how os.macosx.version.major is reported, but instead essentially splitting on the first . and concatenating the second set, it would be more correct to split into 3 and report major/minor/patch.

Current:

❯ facter os.macosx.version                  
{
  full => "11.2.2",
  major => "11",
  minor => "2.2",
}

Proposed:

❯ facter os.macosx.version                  
{
  full => "11.2.2",
  major => "11",
  minor => "2",
  patch => "2"
}

See Apple's API at https://developer.apple.com/documentation/foundation/nsoperatingsystemversion?language=objc

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Apr 22, 2021, 12:34:03 PM4/22/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Labels: community

Gabriel Nagy (Jira)

unread,
Apr 23, 2021, 6:25:01 AM4/23/21
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
May 6, 2021, 1:21:04 PM5/6/21
to puppe...@googlegroups.com
Josh Cooper commented on New Feature FACT-3031
 
Re: Add os.macosx.version.patch fact

Passed CI in 0679e7fb8

Josh Cooper (Jira)

unread,
May 6, 2021, 1:45:03 PM5/6/21
to puppe...@googlegroups.com
Josh Cooper commented on New Feature FACT-3031
 
Re: Add os.macosx.version.patch fact

Is it expected that the fact doesn't have patch on 10.14? I assume so, but wanted to check:

# cat /opt/puppetlabs/puppet/VERSION 
7.6.1.140.g540efbae0
# facter os.macosx.version
{
  full => "10.14.2",
  major => "10.14",
  minor => "2"
}

Josh Cooper (Jira)

unread,
May 6, 2021, 1:48:01 PM5/6/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: FACT 4.1.2

Gabriel Nagy (Jira)

unread,
May 19, 2021, 8:11:04 AM5/19/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Fix Version/s: FACT 4.1.2
Fix Version/s: FACT 4.2.0

Claire Cadman (Jira)

unread,
May 20, 2021, 5:42:05 AM5/20/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: community doc-reviewed

Claudia Petty (Jira)

unread,
Jun 21, 2023, 8:43:05 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: community doc-reviewed new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages