Jira (PDB-5104) Fix schemas that don't handle to_string function data

[Andrei Filipovici (Jira)]

Andrei Filipovici created an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Issue Type: Task Assignee: Unassigned Created: 2021/04/09 9:42 AM Labels: query-engine-improvements Priority: Normal Reporter: Andrei Filipovici Validation done by the row-schema for fact-contents endpoint (https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24) fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this. Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104

Fix schemas that don't handle to_string function data

Change By: Andrei Filipovici Issue Type: Task Bug

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Change By: Andrei Filipovici

Validation done by the row-schema for fact-contents endpoint (https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24) fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this.

There is a disable unit test with this particular issue. It has to be enabled once this is fixed.

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data

Change By: Andrei Filipovici Team: Ghost

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Change By: Andrei Filipovici

Validation done by the row-schema for fact-contents endpoint (https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24) fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this.

This can be reproduced with this query: There is a disable disabled unit test with this particular issue ticket id . It has to be enabled once this is fixed.

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Change By: Andrei Filipovici

Validation done by the row-schema for fact-contents endpoint (https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24) fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this. This can be reproduced with this query:

{code:java} ["extract", [["function", "to_string", "value"]], ["=","name", "uptime_seconds"]] {code} on the facts endpoint. * There is a disabled unit test with this ticket id. It has to be enabled once this is fixed. *

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Change By: Andrei Filipovici

Validation done by the row-schema for fact-contents endpoint (https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24) fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this. This can be reproduced with this query: {code:java} ["extract", [["function", "to_string", "value"]], ["=","name", "uptime_seconds"]] {code} on the facts endpoint.

If you add a formatting parameter after `value`, like "9,999", the query won't fail. Not sure if that's a desired behaviour. *There is a disabled unit test with this ticket id. It has to be enabled once this is fixed.*

Add Comment

[Andrei Filipovici (Jira)]

Andrei Filipovici updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Change By: Andrei Filipovici

Validation done by the row-schema for fact-contents endpoint (https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24) fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this. This can be reproduced with this query: {code:java} ["extract", [["function", "to_string", "value"]], ["=","name", "uptime_seconds"]] {code} on the facts endpoint.

If you add a formatting parameter after `value` mask , like "9,999", the query won't fail , but no result is given . Not sure if that's Do we need a desired behaviour. default formatting mask for integers?

*There is a disabled unit test with this ticket id. It has to be enabled once this is fixed.*

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie commented on PDB-5104

Re: Fix schemas that don't handle to_string function data Add an example in the docs.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5104

Fix schemas that don't handle to_string function data

Change By: Bogdan Irimie Story Points: 5

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data

Change By: Bogdan Irimie Sprint: ghost-30.06.2021

Add Comment

[Sebastian Miclea (Jira)]

Sebastian Miclea assigned an issue to Sebastian Miclea

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data

Change By: Sebastian Miclea Assignee: Sebastian Miclea

Add Comment

[Sebastian Miclea (Jira)]

Sebastian Miclea updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data Change By: Sebastian Miclea

Validation done by the row-schema for fact-contents endpoint

( [ https://github.com/puppetlabs/puppetdb/blob/6.x/src/puppetlabs/puppetdb/query/fact_contents.clj#L10-L24 ] )

fails for rows on which we apply the to_string function. We also need to make sure that there are no other schemas that might throw errors because of this. This can be reproduced with this query:

{code:java} ["extract", [["function", "to_string", "value" , "9999999" ]], ["=","name", "uptime_seconds"]]

{code} on the facts endpoint.

If you add a formatting mask, like "9,999", the query won't fail, but no result is given. Do we need a default formatting mask for integers?

*There is a disabled unit test with this ticket id. It has to be enabled once this is fixed.*

Add Comment

[Rob Browning (Jira)]

Rob Browning updated an issue

PuppetDB / PDB-5104 Fix schemas that don't handle to_string function data

Change By: Rob Browning Fix Version/s: PDB 6.18.0 Fix Version/s: PDB 7.5.0

Add Comment