Jira (FACT-2998) Facter breaks when querying for custom facts

Gheorghe Popescu (Jira)

unread,

Mar 26, 2021, 9:13:04 AM3/26/21

to puppe...@googlegroups.com

Gheorghe Popescu updated an issue

Facter /

FACT-2998

Facter breaks when querying for custom facts

Change By:	Gheorghe Popescu
Summary:	CLI Facter breaks when querying for custom facts

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Gheorghe Popescu (Jira)

unread,

Mar 26, 2021, 9:14:03 AM3/26/21

to puppe...@googlegroups.com

Gheorghe Popescu updated an issue

Facter /

FACT-2998

Facter breaks when querying for custom facts

Change By:	Gheorghe Popescu

When you query for a custom structured fact, Facter uses Hash#dig to cicle through keys, but this can fail if the value of one of the cicled keys is not a Hash.

Simple ruby example:

{code:ruby}
❯ ruby -e '{"a" => "b"}.dig("a", "z")'
Traceback (most recent call last):
1: from -e:1:in `<main>'
-e:1:in `dig': String does not have #dig method (TypeError)
{code}

Steps to reproduce in Facter:
1. create a custom fact

{code:ruby}
Facter.add('foo.bar') do
setcode { 'baz' }
end
{code}

Query for that fact name and an extra key:

{code:ruby}
❯ bx facter foo.bar.x

facter-4.0.52/lib/facter/framework/formatters/formatter_helper.rb:28:in `dig': String does not have #dig method (TypeError)
{code}

Same for Facter.value

{code:ruby}
2.7.2 :001 > require 'facter'
2.7.2 :003 > Facter.value('foo.bar.x')
facter-4.0.52/lib/facter/models/fact_collection.rb:22:in `block in value'
NoMethodError (undefined method `fetch' for "baz":String)
{code}

Add Comment

Gheorghe Popescu (Jira)

unread,

Mar 26, 2021, 9:17:03 AM3/26/21

to puppe...@googlegroups.com

Another thing is that for core facts, Facter ignores parts of the query, if it is partial matched:

{code:ruby}
❯ bx facter os.family.xyz
Darwin

2.7.2 :006 > Facter.value('os.family.a.b')
=> "Darwin"
{code}