Jira (FACT-2997) Domain fact cannot be resolved on travis without ffi

22 views
Skip to first unread message

Gheorghe Popescu (Jira)

unread,
Mar 25, 2021, 3:11:03 AM3/25/21
to puppe...@googlegroups.com
Gheorghe Popescu created an issue
 
Facter / Bug FACT-2997
Domain fact cannot be resolved on travis without ffi
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2021/03/25 12:10 AM
Priority: Normal Normal
Reporter: Gheorghe Popescu

https://github.com/puppetlabs/facter/pull/2315 changed the way we resolve hostname on domain, also relying on FFI.
When FFI is not installed, Facter will not continue to search for hostname and domain and it will not resolve the facts.

This was noticed in puppetserver-ca-cli pipeline.

A fix was done in https://github.com/puppetlabs/facter/pull/2318 but this is not sufficient.
If FFI cannot be load, we must log a debug message and continue the search.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Gheorghe Popescu (Jira)

unread,
Mar 25, 2021, 8:53:03 AM3/25/21
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
https://github.com/puppetlabs/facter/pull/2315 changed the way we resolve hostname on domain, also relying on FFI.
When FFI is not installed, Facter will not continue to search for hostname and domain and it will not resolve the facts.

This was noticed in puppetserver-ca-cli pipeline.

A fix was done in https://github.com/puppetlabs/facter/pull/2318 but this is not sufficient.
If FFI cannot be load loaded , we must log a debug message and continue the search.

Jake Spain (Jira)

unread,
Mar 25, 2021, 9:27:04 AM3/25/21
to puppe...@googlegroups.com
Jake Spain commented on Bug FACT-2997
 
Re: Domain fact cannot be resolved on travis without ffi

We also started experiencing a similar issue when the facter gem was bumped from 4.0.51 to 5.0.52 with tests run by cd4pe on puppetlabs-modules. Here is an example of a failing job #6253, which boils down to the fact "$trusted['certname']" being unable to resolve anywhere in our profiles, such as this.

 

I can reproduce the failure locally by downloading the version of the control repo used for testing here, extracting and cd into the tarball dir and running "docker run --rm -v ~/.ssh:/root/.ssh -v $(PWD)/jobs/unix:/cd4pe_job -v $(PWD)/repo:/repo genebean/puppet-dev-tools:update-testing "/cd4pe_job/JOB"".

Jake Spain (Jira)

unread,
Mar 25, 2021, 9:28:04 AM3/25/21
to puppe...@googlegroups.com

Mihai Buzgau (Jira)

unread,
Mar 26, 2021, 2:14:05 AM3/26/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2021-03-31

Mihai Buzgau (Jira)

unread,
Mar 26, 2021, 2:14:05 AM3/26/21
to puppe...@googlegroups.com

Mihai Buzgau (Jira)

unread,
Mar 26, 2021, 2:49:03 AM3/26/21
to puppe...@googlegroups.com

Gheorghe Popescu (Jira)

unread,
Mar 30, 2021, 3:09:02 AM3/30/21
to puppe...@googlegroups.com

Gheorghe Popescu (Jira)

unread,
Mar 30, 2021, 3:09:03 AM3/30/21
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Affects Version/s: FACT 4.0.52

Gheorghe Popescu (Jira)

unread,
Mar 30, 2021, 3:09:03 AM3/30/21
to puppe...@googlegroups.com
Gheorghe Popescu updated an issue
Change By: Gheorghe Popescu
Release Notes Summary: Fixed a bug that prevented FQDN facts to be resolved in certain situations where FFI is not installed.

Josh Cooper (Jira)

unread,
Mar 30, 2021, 11:42:04 AM3/30/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: FACT 4.0.53

Claire Cadman (Jira)

unread,
Apr 13, 2021, 9:22:01 AM4/13/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: customer0 doc_reviewed
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages