Jira (FACT-2995) check.sh script failing randomly on Ubuntu 20.04

Ciprian Badescu (Jira)

unread,

Mar 24, 2021, 11:49:03 AM3/24/21

to puppe...@googlegroups.com

Ciprian Badescu created an issue

Facter /

FACT-2995

check.sh script failing randomly on Ubuntu 20.04

Issue Type:	Task
Assignee:	Unassigned
Created:	2021/03/24 8:48 AM
Priority:	Normal
Reporter:	Ciprian Badescu

The readme file instructs you to use check.sh to validate your changes.

check.sh script executes `bundle exec rspec --order random` and fails randomly, while `bundle exec rspec` seems to always pass

  1) Facter::Resolvers::OsRelease when on opensuse-leap returns os identifier

     Failure/Error: expect(result).to eq('opensuse')

       expected: "opensuse"

            got: "ubuntu"

       (compared using ==)

     # ./spec/facter/resolvers/os_release_spec.rb:98:in `block (3 levels) in <top (required)>'

  1) Facter::Resolvers::OsRelease when on Debian returns os PRETTY_NAME

     Failure/Error: expect(result).to eq('Debian GNU/Linux 10 (buster)')

       expected: "Debian GNU/Linux 10 (buster)"

            got: "Ubuntu 20.04.1 LTS"

       (compared using ==)

     # ./spec/facter/resolvers/os_release_spec.rb:70:in `block (3 levels) in <top (required)>'

  1) Facter::Resolvers::OsRelease when on Ubuntu returns os identifier

     Failure/Error: expect(result).to eq('')

       expected: ""

            got: "ubuntu"

       (compared using ==)

     # ./spec/facter/resolvers/os_release_spec.rb:44:in `block (3 levels) in <top (required)>'

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Mihai Buzgau (Jira)

unread,

Apr 13, 2021, 9:28:01 AM4/13/21

to puppe...@googlegroups.com

Mihai Buzgau updated an issue

Facter /

FACT-2995

check.sh script failing randomly on Ubuntu 20.04

Change By:	Mihai Buzgau
Team:	Night's Watch

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

Mihai Buzgau (Jira)

unread,

Apr 13, 2021, 9:28:01 AM4/13/21

to puppe...@googlegroups.com

Mihai Buzgau updated an issue

Facter /

FACT-2995

check.sh script failing randomly on Ubuntu 20.04

Change By:	Mihai Buzgau
Sprint:	NW-2021-04-28

Add Comment

Ciprian Badescu (Jira)

unread,

Apr 14, 2021, 5:04:02 AM4/14/21

to puppe...@googlegroups.com

Ciprian Badescu updated an issue

Facter /

FACT-2995

check.sh script failing randomly on Ubuntu 20.04

Change By:	Ciprian Badescu

# Add random order for test execution in github actions (and fix tests if failing)
# Replace check.sh usage with a meta-rake task that will run same tasks as github actions
# Update readme

The readme file instructs you to use check.sh to validate your changes.

check.sh script executes `bundle exec rspec --order random` and fails randomly, while `bundle exec rspec` seems to always pass

{code:java}

  1) Facter::Resolvers::OsRelease when on opensuse-leap returns os identifier
     Failure/Error: expect(result).to eq('opensuse')

       expected: "opensuse"
            got: "ubuntu"

       (compared using ==)
     # ./spec/facter/resolvers/os_release_spec.rb:98:in `block (3 levels) in <top (required)>'

{code}
{code:java}

  1) Facter::Resolvers::OsRelease when on Debian returns os PRETTY_NAME
     Failure/Error: expect(result).to eq('Debian GNU/Linux 10 (buster)')

       expected: "Debian GNU/Linux 10 (buster)"
            got: "Ubuntu 20.04.1 LTS"

       (compared using ==)
     # ./spec/facter/resolvers/os_release_spec.rb:70:in `block (3 levels) in <top (required)>'

{code}
{code:java}

  1) Facter::Resolvers::OsRelease when on Ubuntu returns os identifier
     Failure/Error: expect(result).to eq('')

       expected: ""
            got: "ubuntu"

       (compared using ==)
     # ./spec/facter/resolvers/os_release_spec.rb:44:in `block (3 levels) in <top (required)>'

{code}