Jira (PDB-5064) Handle \0x00 byte error and return a generic error message

[Austin Blatt (Jira)]

Austin Blatt created an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message Issue Type: Task Assignee: Unassigned Created: 2021/03/16 4:18 PM Priority: Normal Reporter: Austin Blatt Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Austin Blatt You can reproduce the error in with {code} curl -G 'http://localhost:8080/pdb/query/v4?query=nodes\{certname="foo%00"\}' --output - {code} curl needs the {{--output -}} flag to allow printing the null byte to the terminal.

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Austin Blatt Acceptance Criteria: - Catch the error and ensure the error message is just {{ERROR: invalid byte sequence for encoding "UTF8": 0x00}}

Add Comment

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Zachary Kent Labels: tsr-pdb-backlog

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Austin Blatt

You can reproduce the error in with {code} curl -G 'http://localhost:8080/pdb/query/v4?query=nodes\{certname="foo%00"\}' --output - {code} curl needs the {{--output -}} flag to allow printing the null byte to the terminal.

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message Change By: Austin Blatt

In addition to removing the stack trace (PDB-5063) we want to omit java/postgresql related information from this error message. Specifically, the existing response includes {{javax.servlet.ServletException}} and {{org.postgresql.util.PSQLException}}, both of which we want to ensure do not get returned (but they can still be in the logs). You can reproduce the error with

{code} curl -G 'http://localhost:8080/pdb/query/v4?query=nodes\{certname="foo%00"\}' --output - {code} curl needs the {{--output -}} flag to allow printing the null byte to the terminal.

Add Comment

[Austin Blatt (Jira)]

Austin Blatt updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message Change By: Austin Blatt

In addition to removing the stack trace (PDB-5063) we want to omit java/postgresql related information from this error message. Specifically, the existing response includes {{javax.servlet.ServletException}} and {{org.postgresql.util.PSQLException}}, both of which we want to ensure do not get returned by the API endpoint (but they can still be in the logs).

You can reproduce the error with {code} curl -G 'http://localhost:8080/pdb/query/v4?query=nodes\{certname="foo%00"\}' --output - {code} curl needs the {{--output -}} flag to allow printing the null byte to the terminal.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Bogdan Irimie Team: HA Ghost

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Bogdan Irimie Sprint: ghost-7.04.2021 Story Points: 3

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie assigned an issue to Oana Tanasoiu

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Bogdan Irimie Assignee: Oana Tanasoiu

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Mihai Buzgau Labels: 2021-o1-kr2 c1 tsr-pdb-backlog

Add Comment

[Oana Tanasoiu (Jira)]

Oana Tanasoiu updated an issue

PuppetDB / PDB-5064 Handle \0x00 byte error and return a generic error message

Change By: Oana Tanasoiu Release Notes Summary: Description of the problem: When a \0x00 byte error is raised the existing response includes javax.servlet.ServletException and org.postgresql.util.PSQLException. Description of the fix: Only show the error message without the stacktrace and without the exception type class . (This was solved by the changes introduced for https://tickets.puppetlabs.com/browse/PDB-5063 )

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)