Jira (FACT-2985) Facter 4 outputs os.distro.description differently on Debian 9

[Gabriel Nagy (Jira)]

Luchian Nemes created an issue

Facter / FACT-2985 Facter 4 outputs os.distro.description differently on Debian 9 Issue Type: Bug Assignee: Unassigned Created: 2021/03/16 7:09 AM Priority: Normal Reporter: Luchian Nemes Running puppet facts diff on macOS gives the following output: { "mountpoints./Volumes/puppet-agent-6.21.1.28.g8d35b8853-1.osx10.14.options.0": { "new_value": "read-only", "old_value": "readonly" } There is an extra hyphen for readonly in the mountpoint options in Facter 4. This is probably the culprit in 3: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/bsd/filesystem_resolver.cc#L55. On the other hand, Facter 4, uses sys-filesystem: https://github.com/djberg96/sys-filesystem/blob/9880f127465e680534263ec0de078179d73ef18b/lib/sys/unix/sys/filesystem.rb#L16 Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Facter / FACT-2985 Facter 4 outputs os.distro.description differently on Debian 9

Change By: Gabriel Nagy Running *puppet facts diff* on macOS Debian 9 gives the following output: {code:json}       {         " mountpoints os . /Volumes/puppet-agent-6 distro . 21.1.28.g8d35b8853-1.osx10.14.options.0 description ": {           "new_value": " read-only Debian GNU/Linux 9 (stretch) ",           "old_value": " readonly Debian GNU/Linux 9.0 (stretch) "         } {code} There The minor version is an extra hyphen for {{readonly}} missing in the mountpoint options in Facter 4 . This is probably the culprit in 3: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/bsd/filesystem_resolver.cc#L55.

On the other hand, Facter 4, uses sys-filesystem: https://github.com/djberg96/sys-filesystem/blob/9880f127465e680534263ec0de078179d73ef18b/lib/sys/unix/sys/filesystem.rb#L16

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-2985

Re: Facter 4 outputs os.distro.description differently on Debian 9 Facter 3 executes lsb_release -a, while Facter 4 parses /etc/os-release: root@smooth-pear:~# lsb_release -d Description: Debian GNU/Linux 9.0 (stretch) root@smooth-pear:~# grep PRETTY_NAME /etc/os-release PRETTY_NAME="Debian GNU/Linux 9 (stretch)" We should add a known limitation as this will affect puppet facts diff Claire Cadman

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Facter / FACT-2985

Facter 4 outputs os.distro.description differently on Debian 9

Change By: Claire Cadman Labels: doc_reviewed known-issue-added

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Facter / FACT-2985 Facter 4 outputs os.distro.description differently on Debian 9

Change By: Ciprian Badescu Epic Link: FACT-3051

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2985 Facter 4 outputs os.distro.description differently on Debian 9

Change By: Josh Cooper Component/s: Facter 4

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-2985

Re: Facter 4 outputs os.distro.description differently on Debian 9 We don't have plans on changing Facter 4, so I'm going to close this.

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)