Jira (FACT-2983) Facter 4 outputs ldom facts differently on Solaris SPARC

17 views
Skip to first unread message

Gabriel Nagy (Jira)

unread,
Mar 16, 2021, 9:59:02 AM3/16/21
to puppe...@googlegroups.com
Luchian Nemes created an issue
 
Facter / Bug FACT-2983
Facter 4 outputs ldom facts differently on Solaris SPARC
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2021/03/16 6:58 AM
Priority: Normal Normal
Reporter: Luchian Nemes

Running puppet facts diff on Solaris 11 gives the following output:

        "mountpoints./proc.available": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./proc.available_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./proc.capacity": {
 
          "new_value": null,
 
          "old_value": "100%"
 
        },
 
        "mountpoints./proc.device": {
 
          "new_value": null,
 
          "old_value": "proc"
 
        },
 
        "mountpoints./proc.filesystem": {
 
          "new_value": null,
 
          "old_value": "proc"
 
        },
 
        "mountpoints./proc.options.0": {
 
          "new_value": null,
 
          "old_value": "dev=8600000"
 
        },
 
        "mountpoints./proc.size": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./proc.size_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./proc.used": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./proc.used_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./system/contract.available": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./system/contract.available_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./system/contract.capacity": {
 
          "new_value": null,
 
          "old_value": "100%"
 
        },
 
        "mountpoints./system/contract.device": {
 
          "new_value": null,
 
          "old_value": "ctfs"
 
        },
 
        "mountpoints./system/contract.filesystem": {
 
          "new_value": null,
 
          "old_value": "ctfs"
 
        },
 
        "mountpoints./system/contract.options.0": {
 
          "new_value": null,
 
          "old_value": "dev=8680001"
 
        },
 
        "mountpoints./system/contract.size": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./system/contract.size_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./system/contract.used": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./system/contract.used_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./system/object.available": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./system/object.available_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./system/object.capacity": {
 
          "new_value": null,
 
          "old_value": "100%"
 
        },
 
        "mountpoints./system/object.device": {
 
          "new_value": null,
 
          "old_value": "objfs"
 
        },
 
        "mountpoints./system/object.filesystem": {
 
          "new_value": null,
 
          "old_value": "objfs"
 
        },
 
        "mountpoints./system/object.options.0": {
 
          "new_value": null,
 
          "old_value": "dev=8740001"
 
        },
 
        "mountpoints./system/object.size": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./system/object.size_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },
 
        "mountpoints./system/object.used": {
 
          "new_value": null,
 
          "old_value": "0 bytes"
 
        },
 
        "mountpoints./system/object.used_bytes": {
 
          "new_value": null,
 
          "old_value": 0
 
        },

More info: https://docs.google.com/document/d/1QlX_mv17fZ4eVZa9zHxvTRVJ5sq88aj3GjUC6lVFiz0/edit#heading=h.gnnvlmulav1v

Some mountpoints are not reported at all by Facter 4. Facter 3 parses /etc/mnttab for mountpoints, while Facter 4 uses the sys-filesystem gem.

Relevant Facter 3 code: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/solaris/filesystem_resolver.cc#L34
Relevant Facter 4 code: https://github.com/puppetlabs/facter/blob/main/lib/facter/resolvers/solaris/mountpoints.rb#L32
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Gabriel Nagy (Jira)

unread,
Mar 16, 2021, 10:05:05 AM3/16/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Running *puppet facts diff* on Solaris 11 SPARC gives the following output:
{code:json}
        " mountpoints hypervisors . /proc ldom . available role_control ": {
          "new_value": null,
           " old_value false " : "0 bytes"
        } ,
        " mountpoints./proc.available_bytes": {
          "new_value": null,
          " old_value": 0 false
        },
        " mountpoints hypervisors . /proc ldom . capacity role_io ": {
          "new_value": null,
           " old_value false " : "100%"
        } ,
        " mountpoints./proc.device": {
          "new_value": null,
          " old_value": "proc" false
        },
        " mountpoints hypervisors . /proc ldom . filesystem role_root ": {
          "new_value": null,
           " old_value false " : "proc"
        } ,
        " mountpoints./proc.options.0": {
          "new_value": null,
          " old_value": "dev=8600000" false
        },
        " mountpoints hypervisors . /proc ldom . size role_service ": {
          "new_value": null,
           " old_value false " : "0 bytes"
        } ,
        " mountpoints./proc.size_bytes": {
          "new_value": null,
          " old_value": 0 false
        },
         "mountpoints./proc.used": {
{ code}

 More info: [https://docs.google.com/document/d/1QlX_mv17fZ4eVZa9zHxvTRVJ5sq88aj3GjUC6lVFiz0/edit#heading=h.gnnvlmulav1v]

Some mountpoints are not reported at all by This may be due to how Facter 4. Facter 3 parses {{/etc/mnttab}} for mountpoints represents boolean values in general , while Facter 4 uses as ldom facts appear to be strings when placed in the {{sys-filesystem}} gem.

Relevant Facter 3 code collection : https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/solaris/ filesystem_resolver ldom_resolver .cc# L34
Relevant Facter 4 code: https://github.com/puppetlabs/facter/blob/main/lib/facter/resolvers/solaris/mountpoints.rb#L32 L55

Mihai Buzgau (Jira)

unread,
Mar 17, 2021, 6:25:03 AM3/17/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Story Points: 2

Mihai Buzgau (Jira)

unread,
Mar 17, 2021, 6:25:03 AM3/17/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2021-03-31

Gabriel Nagy (Jira)

unread,
Mar 26, 2021, 11:04:04 AM3/26/21
to puppe...@googlegroups.com
Gabriel Nagy assigned an issue to Gabriel Nagy
Change By: Gabriel Nagy
Assignee: Gabriel Nagy

Josh Cooper (Jira)

unread,
Mar 30, 2021, 12:03:03 PM3/30/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: FACT 4.0.53

Mihai Buzgau (Jira)

unread,
Mar 31, 2021, 5:31:03 AM3/31/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2021-03-31 , NW - 2021-04-14

Josh Cooper (Jira)

unread,
Apr 1, 2021, 2:08:02 PM4/1/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug FACT-2983
 
Re: Facter 4 outputs ldom facts differently on Solaris SPARC

Merged to main in d5433dcbd8f56852b90fc561276d937d4491ee90

Gabriel Nagy (Jira)

unread,
Apr 13, 2021, 7:48:04 AM4/13/21
to puppe...@googlegroups.com
Gabriel Nagy commented on Bug FACT-2983

Follow-up merged to main in 4571ea0c29d5ca1965c88d093b5ec58ca7f40fdd
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Claire Cadman (Jira)

unread,
Apr 13, 2021, 9:27:05 AM4/13/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
 
Change By: Claire Cadman
Labels: doc_reviewed
Reply all
Reply to author
Forward
0 new messages