Jira (PUP-10947) Revist the exclude_list for puppet facts diff command

Gheorghe Popescu (Jira)

unread,

Mar 3, 2021, 2:26:01 AM3/3/21

to puppe...@googlegroups.com

Gheorghe Popescu created an issue

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Issue Type:	Improvement
Assignee:	Unassigned
Created:	2021/03/02 11:25 PM
Priority:	Normal
Reporter:	Gheorghe Popescu

We should revisit the exclude list from puppet facts diff command(https://github.com/puppetlabs/puppet/blob/6.x/lib/puppet/face/facts.rb#L5-L26) and make sure that only volatile facts are excluded.
We can also check and update the test that puppet-agent is running: https://github.com/puppetlabs/puppet-agent/blob/6.x/acceptance/tests/ensure_facter_3_and_facter_4_output_matches.rb

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

Gheorghe Popescu (Jira)

unread,

Mar 3, 2021, 2:27:01 AM3/3/21

to puppe...@googlegroups.com

Gheorghe Popescu updated an issue

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Change By:	Gheorghe Popescu
Labels:	tech-debt

Add Comment

Mihai Buzgau (Jira)

unread,

Mar 3, 2021, 3:00:02 AM3/3/21

to puppe...@googlegroups.com

Mihai Buzgau updated an issue

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Change By:	Mihai Buzgau
Sprint:	NW - 2021-03-17

Add Comment

Mihai Buzgau (Jira)

unread,

Mar 3, 2021, 6:16:03 AM3/3/21

to puppe...@googlegroups.com

Mihai Buzgau updated an issue

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Change By:	Mihai Buzgau
Story Points:	3

Add Comment

Luchian Nemes (Jira)

unread,

Mar 5, 2021, 3:16:01 AM3/5/21

to puppe...@googlegroups.com

Luchian Nemes assigned an issue to Luchian Nemes

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Change By:	Luchian Nemes
Assignee:	Luchian Nemes

Add Comment

Josh Cooper (Jira)

unread,

Mar 9, 2021, 5:08:03 PM3/9/21

to puppe...@googlegroups.com

Josh Cooper updated an issue

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Change By:	Josh Cooper
Fix Version/s:	PUP 6.22.0

Add Comment

Luchian Nemes (Jira)

unread,

Mar 10, 2021, 3:27:03 AM3/10/21

to puppe...@googlegroups.com

Luchian Nemes commented on

PUP-10947

Re: Revist the exclude_list for puppet facts diff command

Draft doc:

https://docs.google.com/document/d/1hibj5FP2M4qkXxyeF-ZhhDloaphe5DUaINTRMfHSPwM/edit?usp=sharing

Add Comment

Luchian Nemes (Jira)

unread,

Mar 11, 2021, 3:03:01 AM3/11/21

to puppe...@googlegroups.com

Luchian Nemes commented on

PUP-10947

Re: Revist the exclude_list for puppet facts diff command

Remade the doc: https://docs.google.com/document/d/1QlX_mv17fZ4eVZa9zHxvTRVJ5sq88aj3GjUC6lVFiz0/edit?usp=sharing (aix included in test targets and compressed the information)

Add Comment

Luchian Nemes (Jira)

unread,

Mar 11, 2021, 11:55:02 AM3/11/21

to puppe...@googlegroups.com

Luchian Nemes commented on

PUP-10947

Re: Revist the exclude_list for puppet facts diff command

Opened https://github.com/puppetlabs/puppet/pull/8538 with conclusions from above doc and fix proposal.

Add Comment

Luchian Nemes (Jira)

unread,

Mar 15, 2021, 11:25:03 AM3/15/21

to puppe...@googlegroups.com

Luchian Nemes updated an issue

Puppet /

PUP-10947

Revist the exclude_list for puppet facts diff command

Change By:	Luchian Nemes
Release Notes:	Bug Fix
Release Notes Summary:	The `puppet facts diff` cli command filters its output based on a exclude list. This has been updated to only contain the volatile facts (those that are expected to change value between consecutive runs of Facter).