Jira (FACT-2950) Root of structured core facts cannot be overriden by a custom fact

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact Change By: Bogdan Irimie Summary: Structured Root of structured core facts cannot be overriden by a custom fact Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Gheorghe Popescu (Jira)]

Gheorghe Popescu commented on FACT-2950

Re: Root of structured core facts cannot be overriden by a custom fact This issue is affecting modules unit tests that are running with a Puppet 7 that contains the following change(https://github.com/puppetlabs/puppet/commit/c8cea4478f0810d8f20cbc2148b7ad37029a7e57). An example can be seen on puppetlabs-puppet_agent module: https://github.com/puppetlabs/puppetlabs-puppet_agent/runs/2001456000?check_suite_focus=true This happens because rspec-puppet uses facterdb data to create custom facts in order to stub core system facts. For the `os` fact, it uses the following data: stubbing os with: {"architecture"=>"x64", "family"=>"windows", "hardware"=>"x86_64", "name"=>"windows", "release"=>{"full"=>"2016", "major"=>"2016"}, "windows"=>{"edition_id"=>"ServerStandard", "installation_type"=>"Server", "product_name"=>"Windows Server 2016 Standard", "release_id"=>"1607", "system32"=>"C:\\Windows\\system32"}} This will overwrite only the top `os` fact. If any child fact, like `os.name` is called, that fact will be retrieved from system, resulting in unexpected tests behaviour.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

Facter / FACT-2950

Root of structured core facts cannot be overriden by a custom fact

Change By: Bogdan Irimie Facter represents structured facts as a list of path paths e.g. {code}os => {   architecture => "x86_64",   family => "Darwin",   ...   release => {     full => "20.3.0",     major => "20",     minor => "3"   } } {code} will be represented as {code}os.architecture os.family os.release.full os.release.major os.release.minor {code} "os" is never represented as a fact name. When we create a custom fact "os", we don't override the list of facts, we just create a new fact and add it to that list {code}os os.architecture os.family os.release.full os.release.major os.release.minor {code}

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Mihai Buzgau Sprint: NW - 2021-03-17

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Mihai Buzgau Story Points: 3

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu assigned an issue to Gheorghe Popescu

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Gheorghe Popescu Assignee: Gheorghe Popescu

Add Comment

[Dorin Pleava (Jira)]

Dorin Pleava updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Dorin Pleava Fix Version/s: FACT 4.0.52

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-2950

Re: Root of structured core facts cannot be overriden by a custom fact Merged to main in https://github.com/puppetlabs/facter/commit/d4266f065cd1dbf8116a2f9188b179453f414033, passed CI in facter#3390419c5

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu updated an issue

Facter / FACT-2950

Root of structured core facts cannot be overriden by a custom fact

Change By: Gheorghe Popescu Release Notes: Bug Fix

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Gheorghe Popescu Release Notes Summary: Because the top-level fact does not exist, the root of structured core facts could not be overridden by a custom fact. This PR updates the QueryParser logic to return the root fact, if that present in the loaded facts list, thus allowing completely redefinition of core facts.

Add Comment

[Gheorghe Popescu (Jira)]

Gheorghe Popescu updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Gheorghe Popescu Release Notes Summary: Because the top-level fact does not exist, the root of structured core facts could not be overridden by a custom fact. This PR change updates the QueryParser logic to return the root fact, if that present in the loaded facts list, thus allowing completely redefinition of core facts.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Facter / FACT-2950 Root of structured core facts cannot be overriden by a custom fact

Change By: Claire Cadman Labels: doc_reviewed

Add Comment