Jira (PUP-10925) Default timeout not respected for Windows services

13 views
Skip to first unread message

Gabriel Nagy (Jira)

unread,
Feb 18, 2021, 11:02:03 AM2/18/21
to puppe...@googlegroups.com
Gabriel Nagy created an issue
 
Puppet / Bug PUP-10925
Default timeout not respected for Windows services
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2021/02/18 8:01 AM
Priority: Normal Normal
Reporter: Gabriel Nagy

Puppet Version: 6.21.1
Puppet Server Version: n/a
OS Name/Version: Windows

Windows services have a timeout for service-related operations that defaults to 30 seconds, as seen here: https://github.com/puppetlabs/puppet/blob/e4a654400a4c1ad3b5bc73fb558d28219a4626b2/lib/puppet/util/windows/service.rb#L24

This variable is used in the following method: https://github.com/puppetlabs/puppet/blob/c6412ea369aa1613ca166b10fb819fcf6130814b/lib/puppet/provider/service/windows.rb#L118

The method is called in the base service type: https://github.com/puppetlabs/puppet/blob/e4a654400a4c1ad3b5bc73fb558d28219a4626b2/lib/puppet/type/service.rb#L301

Desired Behavior:

Not setting the timeout parameter on a Windows service should cause it to default to 30 seconds.

Actual Behavior:

Not setting the timeout parameter on a Windows services causes it to default to 10 seconds.

 

The line in the service type should change from:

defaultto { provider.class.respond_to?(:default_timeout) ? provider.default_timeout : 10 }

to

defaultto { provider.respond_to?(:default_timeout) ? provider.default_timeout : 10 }

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Feb 18, 2021, 11:10:04 AM2/18/21
to puppe...@googlegroups.com

Mihai Buzgau (Jira)

unread,
Feb 23, 2021, 10:18:13 AM2/23/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: ready for triage Triaged tickets

Ciprian Badescu (Jira)

unread,
Sep 7, 2021, 3:35:02 AM9/7/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Sprint: Triaged tickets NW - 2021-09-22
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Ciprian Badescu (Jira)

unread,
Sep 7, 2021, 3:37:03 AM9/7/21
to puppe...@googlegroups.com

Luchian Nemes (Jira)

unread,
Sep 8, 2021, 7:47:03 AM9/8/21
to puppe...@googlegroups.com

Ciprian Badescu (Jira)

unread,
Sep 14, 2021, 7:14:02 AM9/14/21
to puppe...@googlegroups.com
Ciprian Badescu updated an issue
Change By: Ciprian Badescu
Fix Version/s: PUP 7.12.0
Fix Version/s: PUP 6.25.0

Luchian Nemes (Jira)

unread,
Sep 16, 2021, 7:10:02 AM9/16/21
to puppe...@googlegroups.com
Luchian Nemes updated an issue
Change By: Luchian Nemes
Release Notes: Bug Fix
Release Notes Summary: This fix allows provider to be asked for default timeout value for syncing service properties when it has one instead of always defaulting to 10. This was causing issues on Windows when services were taking more than 10 seconds to change state or sync properties instead of waiting for 30 seconds as the provider was set to.

Claire Cadman (Jira)

unread,
Oct 5, 2021, 8:10:03 AM10/5/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: community doc-reviewed
Reply all
Reply to author
Forward
0 new messages