Jira (FACT-2943) Fix os.name detection of AlmaLinux

33 views
Skip to first unread message

Christoph Schug (Jira)

unread,
Feb 17, 2021, 8:30:03 AM2/17/21
to puppe...@googlegroups.com
Christoph Schug created an issue
 
Facter / Bug FACT-2943
Fix os.name detection of AlmaLinux
Issue Type: Bug Bug
Affects Versions: FACT 3.y
Assignee: Unassigned
Created: 2021/02/17 5:29 AM
Environment:

Facter 3.14.15

AlmaLinux 8.3 Beta

$ cat /etc/redhat-release
AlmaLinux release 8.3 Beta (Purple Manul)

$ cat /etc/os-release
NAME="AlmaLinux"
VERSION="8.3 (Purple Manul)"
ID="almalinux"
ID_LIKE="rhel centos fedora"
VERSION_ID="8.3"
PLATFORM_ID="platform:el8"
PRETTY_NAME="AlmaLinux 8.3 Beta (Purple Manul)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:almalinux:almalinux:8.3:beta"
HOME_URL="https://almalinux.org/"
BUG_REPORT_URL="https://bugs.almalinux.org/"
 
ALMALINUX_MANTISBT_PROJECT="AlmaLinux-8"
ALMALINUX_MANTISBT_PROJECT_VERSION="8"

Priority: Normal Normal
Reporter: Christoph Schug

AlmaLinux is an upcoming Linux distribution currently in public Beta, released on 2021-02-01. It aims to be a 1:1 compatible clone of Red Hat Enterprise Linux filling the gap of the CentOS Linux, which has been EoL'ed as downstream product.

Right now as of Facter 3.14.15, AlmaLinux is correctly detected as member of the Red Hat-family ("os.family" resolves to "RedHat") but the os.name fact on AlmaLinux incorrectly resolves to "RedHat" instead of "AlmaLinux":

$ facter os
{
  architecture => "x86_64",
  distro => {
    codename => "PurpleManul",
    description => "AlmaLinux release 8.3 Beta (Purple Manul)",
    id => "AlmaLinux",
    release => {
      full => "8.3",
      major => "8",
      minor => "3"
    },
    specification => ":core-4.1-amd64:core-4.1-noarch"
  },
  family => "RedHat",
  hardware => "x86_64",
  name => "RedHat",
  release => {
    full => "8.3",
    major => "8",
    minor => "3"
  },
  selinux => {
    enabled => false
  }
}

As AlmaLinux 8.3 Beta just being out for a few days with the final release being expected later in 2021 Q1, the effect of this change should be little and not introduce any backward-incompatible changes (AlmaLinux 8.3 will be the first release of AlmaLinux, there are no predecessors).

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Christoph Schug (Jira)

unread,
Feb 17, 2021, 9:02:03 AM2/17/21
to puppe...@googlegroups.com
Christoph Schug commented on Bug FACT-2943
 
Re: Fix os.name detection of AlmaLinux

I prepared a commit to fix this issue at https://github.com/cschug/facter/commit/1237cfae360d233b89e0f1f8d435999479b1d553 but currently cannot proceed with a PR as I have no idea how to proceed with the CLA. CONTRIBUTING.md mentions the link http://links.puppet.com/cla which gets redirected to the Puppet homepage, https://puppet.com/. Googleing for Puppet CLA leads me to https://cla.puppet.com/ which just errors out with "We're sorry, but something went wrong.".
Will retry later.

Christoph Schug (Jira)

unread,
Feb 18, 2021, 6:55:03 AM2/18/21
to puppe...@googlegroups.com

Still no luck with the CLA process. Requests to https://cla.puppet.com/ no just timeout retuern a vanilla Nginx "504 Gateway Time-out: error page.

Mihai Buzgau (Jira)

unread,
Feb 23, 2021, 10:29:03 AM2/23/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
 
Change By: Mihai Buzgau
Sprint: Triaged tickets NW - 2021-03-17

Mihai Buzgau (Jira)

unread,
Feb 23, 2021, 10:29:03 AM2/23/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Labels: community

Mihai Buzgau (Jira)

unread,
Feb 23, 2021, 10:29:03 AM2/23/21
to puppe...@googlegroups.com
Mihai Buzgau commented on Bug FACT-2943
 
Re: Fix os.name detection of AlmaLinux

Hi Christoph Schug thank you for your contribution!

We're actively working on making our CLA bot available. I'll let you know once this is up and running.

Mihai Buzgau (Jira)

unread,
Feb 23, 2021, 10:29:03 AM2/23/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Team: Night's Watch

Mihai Buzgau (Jira)

unread,
Feb 23, 2021, 10:29:03 AM2/23/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: Triaged tickets

Vadym Chepkov (Jira)

unread,
Feb 24, 2021, 7:31:03 PM2/24/21
to puppe...@googlegroups.com
Vadym Chepkov commented on Bug FACT-2943
 
Re: Fix os.name detection of AlmaLinux

I imagine similar change needs to be done in Facter 4 as well

Gheorghe Popescu (Jira)

unread,
Feb 25, 2021, 7:27:02 AM2/25/21
to puppe...@googlegroups.com

Christoph Schug (Jira)

unread,
Mar 1, 2021, 8:15:03 AM3/1/21
to puppe...@googlegroups.com

Vadym Chepkov, Facter 4 is fine, apparently it uses a different logic than Facter 3. Tested with Facter version 4.0.51 as provided by the puppet-agent-7.4.1-1.el8 RPM package.

It's just Facter 3 which needed the fix, thanks for the merge!

Mihai Buzgau (Jira)

unread,
Mar 3, 2021, 5:46:01 AM3/3/21
to puppe...@googlegroups.com
Mihai Buzgau commented on Bug FACT-2943

Christoph Schug thanks for your contribution! do you mind if we give you a shout-out for this in our release announcement?

Christoph Schug (Jira)

unread,
Mar 3, 2021, 10:07:02 AM3/3/21
to puppe...@googlegroups.com

Mihai Buzgau, no, I don't mind, it's appreciated

Mihai Buzgau (Jira)

unread,
Mar 10, 2021, 3:42:03 AM3/10/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Release Notes Summary: Facter 3 can now detect AlmaLinux . Contributed by cschug

Josh Cooper (Jira)

unread,
Mar 30, 2021, 11:45:04 AM3/30/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: FACT 3.14.17

Claire Cadman (Jira)

unread,
Apr 14, 2021, 4:23:02 AM4/14/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: community doc_reviewed
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Austin Boyd (Jira)

unread,
Apr 21, 2021, 2:36:02 PM4/21/21
to puppe...@googlegroups.com
Austin Boyd updated an issue
Change By: Austin Boyd
Zendesk Ticket Count: 1
Zendesk Ticket IDs: 44058

Austin Boyd (Jira)

unread,
Apr 21, 2021, 2:36:03 PM4/21/21
to puppe...@googlegroups.com
Austin Boyd updated an issue
Change By: Austin Boyd
Labels: community doc_reviewed jira_escalated
Reply all
Reply to author
Forward
0 new messages