Jira (PDB-5018) Provide way to stop/start command processing using ExecutorService

[Bogdan Irimie (Jira)]

Bogdan Irimie created an issue

PuppetDB / PDB-5018 Provide way to stop/start command processing using ExecutorService Issue Type: Task Assignee: Unassigned Created: 2021/02/10 7:18 AM Priority: Normal Reporter: Bogdan Irimie Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5018 Provide way to stop/start command processing using ExecutorService

Change By: Bogdan Irimie It's possible the that the [Executor|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutorService.html] created in the [GatedThreadpool|https://github.com/puppetlabs/puppetdb/blob/main/src/puppetlabs/puppetdb/threadpool.clj#L89] defrecord. Has the ability to pause incoming tasks. We haven't looked through the docs in detail but it would be worth checking out before going with option 1 to see if this is possible.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5018 Provide way to stop/start command processing using ExecutorService

Change By: Bogdan Irimie Story Points: 5

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5018 Provide way to stop/start command processing using ExecutorService

Change By: Bogdan Irimie Sprint: ghost-24.02.2021

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie updated an issue

PuppetDB / PDB-5018 Provide way to stop/start command processing using ExecutorService Change By: Bogdan Irimie

Provide a way to stop and start command processing, perhaps initially only internally, say via a service method. This should help reduce the complexity/fragility of some of the tests. While we might want to eventually support some public way to control this, that can come later.

It's possible the that the [Executor|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutorService.html] created in the [GatedThreadpool|https://github.com/puppetlabs/puppetdb/blob/main/src/puppetlabs/puppetdb/threadpool.clj#L89] defrecord. Has the ability to pause incoming tasks. We haven't looked through the docs in detail but it would be worth checking out before going with option 1 to see if this is possible.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie assigned an issue to Bogdan Irimie

PuppetDB / PDB-5018 Provide way to stop/start command processing using ExecutorService

Change By: Bogdan Irimie Assignee: Bogdan Irimie

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie commented on PDB-5018

Re: Provide way to stop/start command processing using ExecutorService dochan function receives a thread that implements ExecutorService interface. The actual implementation of the thread pool ThreadPoolExecutor. The ThreadPoolExecutor does not implement `pause`, but an example is given in the docs how one might extend the ThreadPoolExecutor and create a PausableThreadPoolExecutor.

Add Comment

[Bogdan Irimie (Jira)]

Bogdan Irimie commented on PDB-5018

Re: Provide way to stop/start command processing using ExecutorService

After presenting the findings to Zachary Kent and Austin Blatt we decided to go for the implementation proposed by Rob Browning in PDB-4524.

Add Comment