Jira (FACT-2936) Facter::Core::Exectuion set $? test is failing on OSX and Solaris

8 views
Skip to first unread message

Mihai Buzgau (Jira)

unread,
Feb 3, 2021, 2:15:03 PM2/3/21
to puppe...@googlegroups.com
Mihai Buzgau created an issue
 
Facter / Task FACT-2936
Facter::Core::Exectuion set $? test is failing on OSX and Solaris
Issue Type: Task Task
Assignee: Unassigned
Created: 2021/02/03 11:14 AM
Priority: Normal Normal
Reporter: Mihai Buzgau

This feature was tested manually and it works, however the test is failing in our CI. we need to figure out why.

Tested manually with the following fact:
```
Facter.add(:foo) do
setcode do
Facter::Util::Resolution.exec('/usr/bin/false')
"/usr/bin/false exited with code: %

{status}

" %

{status: $?.exitstatus}

end
```
telescopic-item:~ root# env FACTERLIB=$PWD/exit_code_test facter foo
/usr/bin/false exited with code: 1

telescopic-item:~ root# facter --version
4.0.50

telescopic-item:~ root# facter os
 
{
 
  architecture => "x86_64",
 
  family => "Darwin",
 
  hardware => "x86_64",
 
  macosx => {
 
    build => "18C54",
 
    product => "Mac OS X",
 
    version => {
 
      full => "10.14.2",
 
      major => "10.14",
 
      minor => "2"
 
    }
 
  },
 
  name => "Darwin",
 
  release => {
 
    full => "18.2.0",
 
    major => "18",
 
    minor => "2"
 
  }
 
}

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Mihai Buzgau (Jira)

unread,
Feb 4, 2021, 4:38:04 AM2/4/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Story Points: 1

Mihai Buzgau (Jira)

unread,
Feb 4, 2021, 4:38:04 AM2/4/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2021-02-17

Mihai Buzgau (Jira)

unread,
Feb 4, 2021, 4:38:04 AM2/4/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Team: Night's Watch

Dorin Pleava (Jira)

unread,
Feb 4, 2021, 6:03:02 AM2/4/21
to puppe...@googlegroups.com
Dorin Pleava assigned an issue to Dorin Pleava
Change By: Dorin Pleava
Assignee: Dorin Pleava

Dorin Pleava (Jira)

unread,
Mar 9, 2021, 7:49:03 AM3/9/21
to puppe...@googlegroups.com
Dorin Pleava updated an issue
Change By: Dorin Pleava
Fix Version/s: FACT 4.0.52
Reply all
Reply to author
Forward
0 new messages