Jira (PUP-10860) 'startup_time' metric should not include splay time

[Josh Cooper (Jira)]

Josh Cooper moved an issue

Puppet / PUP-10860 'startup_time' metric should not include splay time Change By: Josh Cooper Key: PA PUP - 3547 10860 Affects Version/s: puppet-agent 6.19.0 Affects Version/s: PUP 6.19.0 Project: Puppet Agent Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10860 'startup_time' metric should not include splay time

Change By: Josh Cooper Team: Night's Watch

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10860

Re: 'startup_time' metric should not include splay time Thanks Adam Winberg. Seems like we could record the amount of time spent splaying (in https://github.com/puppetlabs/puppet/blob/5d6412cf5de9ed93d80439c539c1416ecf3216b2/lib/puppet/scheduler/splay_job.rb#L6), yield that time to the block starts the splayed run: https://github.com/puppetlabs/puppet/blob/5d6412cf5de9ed93d80439c539c1416ecf3216b2/lib/puppet/daemon.rb#L158, and pass that time into the `agent.run` method. Then we can leave the "startup_time" as is, or subtract the "splay_time"?

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10860

'startup_time' metric should not include splay time

Change By: Mihai Buzgau Labels: community

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-10860 'startup_time' metric should not include splay time

Change By: Mihai Buzgau Labels: community help_wanted

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu commented on PUP-10860

Re: 'startup_time' metric should not include splay time Thank you for filing this issue. We agree it is likely an improvement, but due to other issues demanding precedence, we don’t anticipate being able to address this any time soon. If you are interested in submitting a patch to the repository for this project at https://github.com/puppetlabs, please open a pull request

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)