Jira (FACT-2923) Domain on Windows should be retrieved priority from registry

[Oana Tanasoiu (Jira)]

Oana Tanasoiu created an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry Issue Type: Bug Assignee: Oana Tanasoiu Created: 2021/01/19 6:45 AM Priority: Normal Reporter: Oana Tanasoiu Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Valters Jansons (Jira)]

Valters Jansons updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Valters Jansons Component/s: Facter 4 Affects Version/s: FACT 4.0.48 Facter 4.0.48 (in [Pull Request 2245|https://github.com/puppetlabs/facter/pull/2245]) resolved a regression in gem-based Facter 4.0.x that did not check for domain name in registry on Windows machines (filed as FACT-2882). This resolution however prioritizes network interface domain names in favor of the registry information. Puppet 6 and Facter 3 prioritized the registry entries, so this is a regression (or at least, a notable change in behavior). This is important for domain-joined machines, which store their domain name information in the registry. They may have a network interface with a different domain name received over DHCP, which may be hard to remove depending on the networking circumstances. For these machines where both network adapters have a domain name, and the registry has a domain name, if there is a mismatch, the argument is that the registry is a more safe option to default to.

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Mihai Buzgau Sprint: NW - 2021-02-03

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Mihai Buzgau Team: Ghost Night's Watch

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Mihai Buzgau Story Points: 1

Add Comment

[Valters Jansons (Jira)]

Valters Jansons commented on FACT-2923

Re: Domain on Windows should be retrieved priority from registry Thank you Oana Tanasoiu for the fast work on Pull Request 2260! Trying to understand the timeline for aligning our upgrade process, so I have to ask: Assuming it merges quickly.. would you know when the next upcoming releases are expected for Facter itself to include the commit? And would you know when the next Puppet 7 release may be tagged including this Facter change? Would that be at the end of the linked sprint (February 3)?

Add Comment

[Oana Tanasoiu (Jira)]

Oana Tanasoiu commented on FACT-2923

Re: Domain on Windows should be retrieved priority from registry

Hi Valters Jansons,   A new release of both Facter and Puppet 7 is scheduled for February.   Thank you for filling the details of this ticket and for reporting this bug!

Add Comment

[Valters Jansons (Jira)]

Valters Jansons commented on FACT-2923

Re: Domain on Windows should be retrieved priority from registry

Oana Tanasoiu, sounds good! Will have to try out a build of the Gem locally until then.

Add Comment

[Oana Tanasoiu (Jira)]

Oana Tanasoiu updated an issue

Facter / FACT-2923

Domain on Windows should be retrieved priority from registry

Change By: Oana Tanasoiu Release Notes: Bug Fix Release Notes Summary: Description of the problem: Facter 4 prioritises network interface domain names over the registry information on Windows. Description of the fix: Retrieve networking domain on Windows with priority from registry.

Add Comment

[Valters Jansons (Jira)]

Valters Jansons commented on FACT-2923

Re: Domain on Windows should be retrieved priority from registry Grabbed the current Facter HEAD (6bcd161) and can confirm facter domain and facter fqdn appear to properly return the operator-configured domain (registry) instead of the infrastructure/adapter one. Thank you!

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2923

Domain on Windows should be retrieved priority from registry

Change By: Josh Cooper Fix Version/s: FACT 4.0.50

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Claire Cadman Labels: doc_reviewed

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Josh Cooper Release Notes Summary: Description of the problem: Facter 4 prioritises network interface domain names over the registry information on Windows. This is a problem because it affects how the agent determines its Puppet[:certname] and can cause agents to try to retrieve a new client certificate under a different name.

Description of the fix: Retrieve networking domain on Windows with priority from registry.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-2923 Domain on Windows should be retrieved priority from registry

Change By: Josh Cooper Release Notes Summary: Description of the problem: Facter 4 prioritises prioritizes network interface domain names over the registry information on Windows. This is a problem because it affects how the agent determines its Puppet[:certname] and can cause agents to try to retrieve a new client certificate under a different name.

Description of the fix: Retrieve networking domain on Windows with priority from registry.

Add Comment