Kenyon pointed out in PR https://github.com/puppetlabs/facter/pull/2241 that some unit tests fail because of improper stubs. I added unit tests. Everything passes locally for me, except for random unit test failures unrelated to my changes, where the test returns facts from my system instead of from fixtures; spec_integration/facter_to_hash_spec.rb tests that return statvfs() function failed: Permission denied, I guess because I'm not running these tests as root. Example of the random failures: 1) Facter::Resolvers::OsRelease when on Oracle Linux returns os NAME Failure/Error: expect(result).to eq('OracleLinux') expected: "OracleLinux" got: "Debian" (compared using ==)
- ./spec/facter/resolvers/os_release_spec.rb:118:in `block (3 levels) in <top (required)>'
|